fix: issuance API with required attribute #528

pranalidhanavade · 2024-02-20T16:50:17Z

What

Fixed issue regarding issuance API with old schema details.

Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

sonarqubecloud · 2024-02-21T17:22:14Z

Quality Gate passed

Issues
2 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ankita-p17 · 2024-02-22T05:02:22Z

apps/issuance/src/issuance.service.ts

-        if (0 < attrError.length) {
-          throw new BadRequestException(attrError);
-        }
+            payload.attributes.map((attr) => { 


@pranalidhanavade It would be better to create a common function for this logic and call from wherever required

ankita-p17

The added comment will be resolved in next PR soon

* fix:issuance api Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix:issuance api issue Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix:sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix:requried attribute in issuance api Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix:requried attributes in csv file Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> --------- Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix:issuance api Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix:issuance api issue Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix:sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix:requried attribute in issuance api Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix:requried attributes in csv file Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> --------- Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com>

* fix:issuance api Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix:issuance api issue Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix:sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix:requried attribute in issuance api Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix:requried attributes in csv file Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> --------- Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix:issuance api Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix:issuance api issue Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix:sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix:requried attribute in issuance api Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix:requried attributes in csv file Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> --------- Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>

* fix:issuance api Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix:issuance api issue Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix:sonarlint issues Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix:requried attribute in issuance api Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> * fix:requried attributes in csv file Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> --------- Signed-off-by: pranalidhanavade <pranali.dhanavade@ayanworks.com> Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com> Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>