Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ld 20250214 cr hapi fhir carveout #631

Draft
wants to merge 29 commits into
base: master
Choose a base branch
from
Draft

Ld 20250214 cr hapi fhir carveout #631

wants to merge 29 commits into from

Conversation

lukedegruchy
Copy link
Contributor

No description provided.

@lukedegruchy
First commit: All files from hapi-fhir-storage-cr. Everything compile…
ebbd06b 
…s and all checkstyle errors fixed. Most unit tests fail. Address some SonarQube feedback.
@lukedegruchy
Tests passing after bumping to hapi-fhir 7.7.18-SNAPSHOT, fixing dire…
b101421 
…ctory structure for test resources, and adding cqf-fhir-jackson, hapi-fhir-converter, and setting commons-codec version to 1.15.
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

Formatting check succeeded!

@codecov Codecov
Copy link

codecov bot commented Feb 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 53.38346% with 620 lines in your changes missing coverage. Please review.

Project coverage is 68.59%. Comparing base (987833a) to head (fc32801).

Files with missing lines Patch % Lines
...ncds/cqf/fhir/cr/hapi/repo/HapiFhirRepository.java 45.56% 84 Missing and 8 partials ⚠️
...ncds/cqf/fhir/cr/hapi/repo/BundleProviderUtil.java 33.62% 63 Missing and 14 partials ⚠️
...qf/fhir/cr/hapi/config/test/TestCqlProperties.java 42.62% 70 Missing ⚠️
...qf/fhir/cr/hapi/config/test/r4/TestCrR4Config.java 59.21% 15 Missing and 16 partials ⚠️
...cds/cqf/fhir/cr/hapi/config/CrConfigCondition.java 0.00% 20 Missing ⚠️
...tion/StructureDefinitionQuestionnaireProvider.java 0.00% 17 Missing ⚠️
...ds/cqf/fhir/cr/hapi/repo/RequestDetailsCloner.java 51.51% 15 Missing and 1 partial ⚠️
.../cr/hapi/dstu3/library/LibraryPackageProvider.java 0.00% 15 Missing ⚠️
.../plandefinition/PlanDefinitionPackageProvider.java 0.00% 15 Missing ⚠️
...u3/questionnaire/QuestionnairePackageProvider.java 0.00% 15 Missing ⚠️
... and 33 more
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #631      +/-   ##
============================================
- Coverage     74.23%   68.59%   -5.64%     
- Complexity       19      268     +249     
============================================
  Files           363      437      +74     
  Lines         19128    21389    +2261     
  Branches       2533     2751     +218     
============================================
+ Hits          14199    14672     +473     
- Misses         3590     5339    +1749     
- Partials       1339     1378      +39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukedegruchy
Sonar: constructor injection and other minor issues.
c861d8b
@lukedegruchy
More sonar warnings.
5985f61
@lukedegruchy
Fix more checkstyle errors.
183de29
@lukedegruchy
More sonar fixes.
7dfb62a
@lukedegruchy
Resolve more sonar issues.
42c8e48
@lukedegruchy
First round of changes to introduce compile against clinical-reasonin…
f66f940 
…g CI scripts.
@lukedegruchy
Temporarily override the branch upon which we're triggering the cdr-c…
9b28f50 
…r build.
@lukedegruchy
Add debugging logs
33f467c
@lukedegruchy
Fix typo.
6255a96
@lukedegruchy
More logging.
b470b1a
@lukedegruchy
Yet more logging.
41839f9
@lukedegruchy
Update poetry and add logging.
7d1d028
@lukedegruchy
Start the process of carving out a separate cqf-fhir-cr-test model an…
929ccef 
…d importing it from cqf-fhir-benchmark.
@lukedegruchy
Step2: Move all test code to cdf-fhir-cr-test and import cqf-fhir-cr-…
a245607 
…test from cqf-fhir-benchmark as test-jar.
@lukedegruchy
Step 3: Move all non-test classes imported by cqf-fhir-benchmark into…
2308511 
… the main source folder and get rid of test-jar. 3 tests in cdf-fhir-cr-test are still failing due to resource not found issues.
@lukedegruchy
Everything's working with lots of duplicate files between main and te…
ae07064 
…st resources.
@lukedegruchy
Merge remote-tracking branch 'origin/master' into ld-20250214-cr-hapi…
8bd1561 
…-fhir-carveout
@lukedegruchy
Fix sonar security warnings. Ensure immediate failure if neither toke…
17d503c 
…n is set.
@lukedegruchy
Rename module to cqf-fhir-cr-hapi.
2977df0
@lukedegruchy
Change package to org.opencds.cqf.fhir.cr.hapi.
e3a5bdf
@lukedegruchy
Spotless.
ad3627d
@lukedegruchy
Add CareGaps interfaces.
45908bf
@lukedegruchy
Tweak performance optimization.
6ed0b56
@lukedegruchy
Return interface from factory instead of class.
e2332ee
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukedegruchy