Fix multiple iterations of an artifact in ReleaseVisitor #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tifact multiple times
|
Formatting check succeeded! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #555 +/- ##
=========================================
Coverage 73.05% 73.06%
Complexity 19 19
=========================================
Files 365 365
Lines 19366 19384 +18
Branches 2957 2963 +6
=========================================
+ Hits 14148 14162 +14
- Misses 3791 3793 +2
- Partials 1427 1429 +2 ☔ View full report in Codecov by Sentry. |
added 2 commits
October 9, 2024 15:22
|
sliver007
approved these changes
Oct 9, 2024
TahaAttari
pushed a commit
that referenced
this pull request
Oct 9, 2024
* Add check to release visitor to prevent iterating through the same artifact multiple times * add short circuit and tests * spotless * reduce complexity --------- Co-authored-by: taha.attari@smilecdr.com <taha.attari@smilecdr.com>
TahaAttari
pushed a commit
that referenced
this pull request
Oct 11, 2024
* Add check to release visitor to prevent iterating through the same artifact multiple times * add short circuit and tests * spotless * reduce complexity --------- Co-authored-by: taha.attari@smilecdr.com <taha.attari@smilecdr.com>
TahaAttari
pushed a commit
that referenced
this pull request
Oct 17, 2024
* Add check to release visitor to prevent iterating through the same artifact multiple times * add short circuit and tests * spotless * reduce complexity --------- Co-authored-by: taha.attari@smilecdr.com <taha.attari@smilecdr.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check to prevent the same artifact from being iterated through multiple times in the ReleaseVisitor if that artifact is referenced by multiple artifacts.