Fix logback-classic on classpath #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Formatting check succeeded! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #541 +/- ##
============================================
- Coverage 72.61% 72.61% -0.01%
Complexity 19 19
============================================
Files 362 362
Lines 18604 18603 -1
Branches 2874 2874
============================================
- Hits 13509 13508 -1
Misses 3734 3734
Partials 1361 1361 ☔ View full report in Codecov by Sentry. |
barhodes
approved these changes
Oct 4, 2024
|
TahaAttari
pushed a commit
that referenced
this pull request
Oct 9, 2024
* Remove logback-classic from classpath * Fix getting events from wrong thread * Fix SonarQube issue * Fix whitespace issues * Fix whitespace part 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logback-classicfrom classpathslf4j-simpletoslf4j-testto allow for unit testsslf4j-test