New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APHL-1075-retire_operation #534

Merged

TahaAttari merged 6 commits into master from APHL-1075-retire_operation

Sep 27, 2024

Contributor

ibaisi commented Sep 26, 2024

retire operation with tests


          retire operation with tests

github-actions bot commented Sep 26, 2024 •

edited

Loading

Formatting check succeeded!

codecov bot commented Sep 26, 2024 •

edited

Loading

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.40%. Comparing base (eecfbf1) to head (87cf711).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...lity/visitor/AbstractKnowledgeArtifactVisitor.java	76.92%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #534      +/-   ##
============================================
+ Coverage     67.35%   67.40%   +0.04%     
- Complexity     4136     4141       +5     
============================================
  Files           354      355       +1     
  Lines         18154    18169      +15     
  Branches       2804     2804              
============================================
+ Hits          12227    12246      +19     
+ Misses         4717     4713       -4     
  Partials       1210     1210

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


          apply formatting

fa17b4a

TahaAttari reviewed

View reviewed changes

...ity/src/main/java/org/opencds/cqf/fhir/utility/visitor/AbstractKnowledgeArtifactVisitor.java Outdated Show resolved Hide resolved

TahaAttari reviewed

View reviewed changes

...ity/src/main/java/org/opencds/cqf/fhir/utility/visitor/AbstractKnowledgeArtifactVisitor.java Show resolved Hide resolved

TahaAttari reviewed

View reviewed changes

...ity/src/main/java/org/opencds/cqf/fhir/utility/visitor/AbstractKnowledgeArtifactVisitor.java Outdated Show resolved Hide resolved

TahaAttari reviewed

View reviewed changes

cqf-fhir-utility/src/main/java/org/opencds/cqf/fhir/utility/visitor/RetireVisitor.java Outdated Show resolved Hide resolved

TahaAttari reviewed

View reviewed changes

cqf-fhir-utility/src/test/java/org/opencds/cqf/fhir/utility/visitor/r4/RetireVisitorTest.java Outdated Show resolved Hide resolved

TahaAttari reviewed

View reviewed changes

cqf-fhir-utility/src/test/java/org/opencds/cqf/fhir/utility/visitor/r4/RetireVisitorTest.java Outdated Show resolved Hide resolved

ibaisismile added 2 commits

September 27, 2024 09:18


          fix PR comments

382ef64


          format code

c2c5bb8

TahaAttari reviewed

View reviewed changes

...ity/src/main/java/org/opencds/cqf/fhir/utility/visitor/AbstractKnowledgeArtifactVisitor.java Outdated Show resolved Hide resolved


          remove redundant check

13dad66

TahaAttari approved these changes

View reviewed changes


          Merge branch 'master' into APHL-1075-retire_operation

87cf711

TahaAttari enabled auto-merge (squash)

September 27, 2024 16:58

TahaAttari merged commit 6e14c44 into master

7 checks passed

TahaAttari deleted the APHL-1075-retire_operation branch

September 27, 2024 17:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet