Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interfaces to R4MeasureService and R4MultiMeasureService. #510

Conversation

lukedegruchy
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Sep 3, 2024

Formatting check succeeded!

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.87%. Comparing base (8d4254a) to head (b22ff7c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #510   +/-   ##
=========================================
  Coverage     66.87%   66.87%           
  Complexity     4057     4057           
=========================================
  Files           349      349           
  Lines         17954    17954           
  Branches       2787     2787           
=========================================
  Hits          12006    12006           
  Misses         4745     4745           
  Partials       1203     1203           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Capt-Mac Capt-Mac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: our other interfaces are in measure/common path, similar to MeasureProcessor interface.

Copy link
Contributor

@Capt-Mac Capt-Mac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Any reason we are doing it at R4 level only?

@lukedegruchy lukedegruchy enabled auto-merge (squash) September 9, 2024 13:14
@lukedegruchy lukedegruchy merged commit 5ea7e8a into master Sep 9, 2024
7 checks passed
@lukedegruchy lukedegruchy deleted the ld-20230903-interfaces-for-r4-single-and-multiple-measure-service branch September 9, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants