Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates to package and expand: #506

Merged
merged 8 commits into from
Aug 22, 2024
Merged

updates to package and expand: #506

merged 8 commits into from
Aug 22, 2024

Conversation

TahaAttari
Copy link
Collaborator

  • refactor out "tryGetLatest"
  • update expandHelper to pull from tx server or repository as applicable
  • boolean bug in expansion handling

updates to package and expand:
04e9eb1 
- refactor out "tryGetLatest"
- update expandHelper to pull from tx server or repository as applicable
- possible bug in expansion handling
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 20, 2024 •
edited
Loading

Formatting check succeeded!

@codecov Codecov
Copy link

codecov bot commented Aug 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 68.49315% with 23 lines in your changes missing coverage. Please review.

Project coverage is 66.80%. Comparing base (bc0b71f) to head (89f6226).
Report is 1 commits behind head on master.

Files Patch % Lines
...ava/org/opencds/cqf/fhir/utility/ExpandHelper.java 70.00% 9 Missing and 6 partials ⚠️
...f/fhir/utility/client/TerminologyServerClient.java 20.00% 7 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #506      +/-   ##
============================================
+ Coverage     66.74%   66.80%   +0.06%     
- Complexity     4020     4037      +17     
============================================
  Files           348      348              
  Lines         17842    17880      +38     
  Branches       2754     2760       +6     
============================================
+ Hits          11908    11945      +37     
+ Misses         4742     4739       -3     
- Partials       1192     1196       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TahaAttari TahaAttari marked this pull request as ready for review August 21, 2024 20:50
sliver007
sliver007 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@sliver007 sliver007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sliver007 sliver007 merged commit 23a78d7 into master Aug 22, 2024
7 checks passed
@sliver007 sliver007 deleted the update-expandhelper-to-pull-leafs branch August 22, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sliver007 sliver007 sliver007 approved these changes

@barhodes barhodes barhodes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TahaAttari @sliver007 @barhodes