Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Reword permissions modal #744

Merged
merged 2 commits into from
Aug 30, 2021
Merged

feat: Reword permissions modal #744

merged 2 commits into from
Aug 30, 2021

Conversation

Ldoppea
Copy link
Member

@Ldoppea Ldoppea commented Aug 25, 2021

Permission modal was not clear enough about what was shared or not

We think that the new wording will fix this problem

Before:

image

After:

image

@Ldoppea
Copy link
Member Author

Ldoppea commented Aug 25, 2021

Note that the distinction between internal (when there are also external permission) and internal_only (when there is no other external permission) is disappearing. I'm waiting for some answers from product-owners but I may merge those two translation entries later.

JF-Cozy
JF-Cozy reviewed Aug 26, 2021
View reviewed changes
Copy link
Contributor

@JF-Cozy JF-Cozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attention CI red

@Ldoppea
feat: Reword permissions modal
f3cb079 
Permission modal was not clear enough about what was shared or not

We think that the new wording will fix this problem
@Ldoppea Ldoppea force-pushed the feat/reword_permissions_modal branch from 2e99935 to 98b621b Compare August 26, 2021 13:43
@Ldoppea
feat: remove only_internal version from permissions descriptions
f84e7c9 
With previous rewording there is no difference between wording for
internal permissions only and wording for internal permissions preceded
by external permissions block

So related code has been simplified by removing translation variant
@Ldoppea Ldoppea force-pushed the feat/reword_permissions_modal branch from 98b621b to f84e7c9 Compare August 26, 2021 18:38
@Ldoppea Ldoppea merged commit 5051539 into master Aug 30, 2021
@Ldoppea Ldoppea deleted the feat/reword_permissions_modal branch August 30, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JF-Cozy JF-Cozy JF-Cozy left review comments

@acezard acezard acezard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ldoppea @acezard @JF-Cozy