Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding callbacks/release/v0.1.x+ibc-go-v7.3.x backport action to mergify #4517

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

srdtrk
Copy link
Member

@srdtrk srdtrk commented Aug 30, 2023

Description

I've decided that the backport should be from main instead of v7.3.x as we contemplated since you don't need to follow a trail of PRs to see where a given PR was backported to. This is more clean and consistent with our other backport tags imo.

closes: #XXXX

Commit Message / Changelog Entry

chore: adding callbacks/release/v0.1.x+ibc-go-v7.3.x backport action to mergify

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@srdtrk srdtrk added the github_actions Pull requests that update Github_actions code label Aug 30, 2023
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@charleenfei charleenfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@srdtrk srdtrk merged commit 72875b2 into main Aug 31, 2023
@srdtrk srdtrk deleted the serdar/mergify-callbacks-workflow-v0.1.x-ibc.v7.3.x branch August 31, 2023 08:53
@srdtrk srdtrk added the callbacks middleware Issues for callbacks middleware label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callbacks middleware Issues for callbacks middleware github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants