Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nits for params migrations #3853

Merged
merged 7 commits into from
Jun 15, 2023
Merged

Conversation

crodriguezvega
Copy link
Contributor

Description

Makes testing of MsgUpdateParams consistent across the board and also addresses #3776.

closes: #3776

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

Merging #3853 (aa5f8eb) into main (4af67c6) will increase coverage by 0.11%.
The diff coverage is 61.53%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3853      +/-   ##
==========================================
+ Coverage   78.76%   78.87%   +0.11%     
==========================================
  Files         187      187              
  Lines       12935    12939       +4     
==========================================
+ Hits        10188    10206      +18     
+ Misses       2317     2305      -12     
+ Partials      430      428       -2     
Impacted Files Coverage Δ
modules/apps/27-interchain-accounts/module.go 51.00% <0.00%> (ø)
modules/apps/transfer/module.go 52.63% <0.00%> (ø)
...nterchain-accounts/controller/keeper/migrations.go 87.50% <100.00%> (+0.40%) ⬆️
...s/27-interchain-accounts/host/keeper/migrations.go 80.00% <100.00%> (+1.42%) ⬆️
modules/apps/transfer/keeper/keeper.go 90.47% <100.00%> (ø)
modules/apps/transfer/keeper/migrations.go 96.29% <100.00%> (ø)
modules/core/02-client/keeper/migrations.go 56.25% <100.00%> (+2.91%) ⬆️
modules/core/03-connection/keeper/migrations.go 60.00% <100.00%> (+2.85%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🥳

@crodriguezvega crodriguezvega merged commit 7850184 into main Jun 15, 2023
@crodriguezvega crodriguezvega deleted the carlos/nits-params-migration branch June 15, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add basic log msg for each params migration handler
5 participants