test: adding e2e upgrade test for v7.1 localhost #3164
Merged
+148
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
commented
Feb 17, 2023
damiannolan
commented
Feb 17, 2023
damiannolan
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei and
chatton
as code owners
chatton
approved these changes
Feb 20, 2023
| @@ -549,6 +551,35 @@ func (s *UpgradeTestSuite) TestV6ToV7ChainUpgrade() { | |||
| }) | |||
| } | |||
|
|
|||
| func (s *UpgradeTestSuite) TestV7ChainUpgradeAddLocalhost() { | |||
There was a problem hiding this comment.
love how simple this test is 🥇
Co-authored-by: Cian Hatton <cian@interchain.io>
|
Pretty cool to have an e2e upgrade migration tests for v7 -> v7.1, with super small diffs! |
colin-axner
reviewed
Feb 20, 2023
e2e/tests/upgrades/upgrade_test.go
Outdated
|
|
||
| t.Run("upgrade chain", func(t *testing.T) { | ||
| govProposalWallet := s.CreateUserOnChainA(ctx, testvalues.StartingTokenAmount) | ||
| s.UpgradeChain(ctx, chain, govProposalWallet, v71.UpgradeName, testCfg.ChainAConfig.Tag, testCfg.UpgradeTag) |
There was a problem hiding this comment.
this needs to be updated?
There was a problem hiding this comment.
updated! need to get the fix in #3172 included in this branch too. The else if we added earlier caused some weird issues in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #3033
Commit Message / Changelog Entry
NA
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.