chore: rename any var to protoAny

[RegisGraptin]

Description

Some variable names are too generic and are not precise in the code. This is the case with some variables named any. A change has been made to rename it protoAny instead.

This modification has been made on the variable names when they were assigned by the functions codectypes.NewAnyWithValue() or clienttypes.PackClientState(). It was partially changed on a previous merge. I do not know if other parts of the code needed to be changed ? Nor the documentation ?

closes: #2890

Commit Message / Changelog Entry

chore: rename any var to protoAny

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md).
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests.
• Updated relevant documentation (docs/) or specification (x/<module>/spec/).
• Added relevant godoc comments.
• Provide a commit message to be used for the changelog entry in the PR description for review.
• Re-reviewed Files changed in the Github PR explorer.
• Review Codecov Report in the comment section below once CI passes.

[damiannolan]

Hey @RegisGraptin, thanks for picking up this issue!

I do not know if other parts of the code needed to be changed ? Nor the documentation ?

I think the documentation is probably fine, but I think there is some more occurrences of any used throughout the codebase. E.g. https://github.com/cosmos/ibc-go/blob/main/modules/apps/27-interchain-accounts/host/keeper/relay.go#L68-L71

I ran a simple string search using any, err as it seems to be harder to grep for just any alone as we get more results than desired

[RegisGraptin]

Hey @damiannolan,

Thanks for your reply.
Okay, I will take a look at the other tuples of variables named any, err and modify it. And have a look on other variables with only any.
I didn't know if all the any variables needed to be modified, as they might need to be named differently depending on the function called. Maybe not protoAny but something else. As an example, I found:

clientAny, err := types.PackClientState(tc.clientState)
...
csAny, _ := clienttypes.PackClientState(counterpartyClient)

Do we need to standardized the naming convention for those two ?

[codecov-commenter]

Codecov Report

Merging #2986 (692381c) into main (65f7038) will increase coverage by 0.00%.
The diff coverage is 91.66%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2986   +/-   ##
=======================================
  Coverage   78.53%   78.53%           
=======================================
  Files         179      179           
  Lines       12436    12437    +1     
=======================================
+ Hits         9767     9768    +1     
  Misses       2243     2243           
  Partials      426      426           

Impacted Files	Coverage Δ
modules/core/02-client/keeper/grpc_query.go	68.33% <75.00%> (ø)
...s/apps/27-interchain-accounts/host/keeper/relay.go	71.08% <100.00%> (ø)
modules/apps/27-interchain-accounts/types/codec.go	79.54% <100.00%> (ø)
...odules/apps/27-interchain-accounts/types/packet.go	81.81% <100.00%> (ø)
modules/core/02-client/types/codec.go	79.59% <100.00%> (ø)
modules/core/02-client/types/proposal.go	87.01% <100.00%> (ø)
modules/core/03-connection/types/msgs.go	85.00% <100.00%> (ø)
modules/core/keeper/msg_server.go	55.17% <100.00%> (+0.09%)	⬆️

[crodriguezvega]

Do we need to standardized the naming convention for those two ?

I would say let's just use the same name (protonAny) everywhere. We can add this to our coding style guide.

[crodriguezvega]

Thanks for the latest updates, @RegisGraptin. Do you think the PR is now ready for review?

[RegisGraptin]

Hey @crodriguezvega. Yes, I think it should be good :)

[damiannolan]

Thanks for the contribution! ❤️

[colin-axner]

Thank you @RegisGraptin! Appreciate the time you took to fix this for us!