ADR 006: 02-client refactor #1846
Conversation
colin-axner
requested review from
AdityaSripal,
crodriguezvega,
seantking,
charleenfei and
damiannolan
as code owners
There was a problem hiding this comment.
Awesome! This is great.
Should we use back-ticked names for function/module references? e.g. 07-tendermint, ClientMessage...etc Don't want to block approval on that nit so feel free to take it or leave it!
Should we also reference ADR 005 - UpdateClient Events - ClientState Consensus Heights as part of this, as we now emit a list of consensus heights?
|
|
||
| ### Tendermint non-zero height upgrades | ||
|
|
||
| Before the launch of IBC, it was determined that the tendermint go implementation would not be capable of supporting non-zero height upgrades. |
There was a problem hiding this comment.
| Before the launch of IBC, it was determined that the tendermint go implementation would not be capable of supporting non-zero height upgrades. | |
| Before the launch of IBC, it was determined that the tendermint-go implementation would not be capable of supporting non-zero height upgrades. |
There was a problem hiding this comment.
maybe it'd be better if I just linked the repo and put "that the golang implementation of tendermint"
There was a problem hiding this comment.
Thank you, @colin-axner!
Should we use back-ticked names for function/module references? e.g. 07-tendermint, ClientMessage...etc Don't want to block approval on that nit so feel free to take it or leave it!
I agree with @damiannolan on this, so if you agree, I have added a bunch of suggestions adding the backticks, so that it's easier for you to update.
|
|
||
| ## Context | ||
|
|
||
| During the initial development of the 02-client submodule, each light client supported (06-solomachine, 07-tendermint, 09-localhost) was referenced through hardcoding. |
There was a problem hiding this comment.
I know that this might be difficult or too much work and this is probably due to my lack of knowledge, but I think it would be super useful for a semi-unfamiliar reader if you add maybe some code sample or links to the code with what you mean with the hardcoding and that new light clients would need to be added directly to the 02-client module.
colin-axner
changed the base branch from
02-client-refactor
to
updated-02-client-refactor
colin-axner
changed the base branch from
updated-02-client-refactor
to
02-client-refactor
colin-axner
force-pushed
the
colin/1299-02-client-refactor-adr
branch
from
a2d4af4 to
4c060e0
Compare
|
Going to merge as I believe I've addressed everyone's suggestions |
Description
closes: #1299
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes