Bump liquidity module v1.4.0 based sdk v0.44.0 #956

dongsam · 2021-08-27T11:14:46Z

Description

This PR is for Bump Cosmos SDK and ibc-go #942 start-upgrade branch
Detailed Progress of liquidity module for SDK v0.43.0 and Gaia Upgrade V1: Porting to based sdk v0.43.0 and v0.44.0 for vega upgrade tendermint/liquidity#432

Liquidity module v1.3.0 is released tendermint/liquidity#439 ( discontinued due to sdk v0.44.0 released )

Fix some issues related to genesis import/export Fix simulation tests tendermint/liquidity#437
Updating docs
the same version of gravity-devs/liquidity v1.3.0 as well, As was the latest version with Gaia, import to gravity-devs/liquidity, not to tendermint/liquidity.
Test and simulate gaia upgrade simulation test based hub-4 states tendermint/liquidity#434, https://github.com/b-harvest/gravity-dex-upgrade-test/tree/kogisin/v5.0.5-upgrade-simulation/v5.0.5

CHANGELOGS

#433 (sdk) Bump SDK version to v0.43.0.
#436 Validation MsgSwapWithinBatch and OfferCoinFee ceiling
- When calculating OfferCoinFee, the decimal points are rounded up.
  - before (v1.2.x): MsgSwapWithinBatch.OfferCoinFee should be OfferCoin * params.SwapFeeRate/2 with Truncate or 0
  - after (v1.3.x): MsgSwapWithinBatch.OfferCoinFee should be OfferCoin * params.SwapFeeRate/2 with Ceil
- Fix reserveOfferCoinFee residual Issue due to decimal error
#438 Fix PoolBatch index, beginHeight issues and genesis logic
- Remove PoolBatchIndex
- Fix PoolBatch.Index duplicated bug
- Fix PoolBatch.BeginHeight consistency issue on genesis init logic

Liquidity module v1.4.0 is released, gravity-devs/liquidity v1.4.0 as well

Add commit for liquidity module bump gravity-devs/liquidity v1.4.0
Update CHANGELOG.md

CHANGELOGS

Bump github.com/cosmos/cosmos-sdk from 0.37.13 to 0.38.5 #440 (sdk) Bump SDK version to v0.44.0

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

…rade

codecov · 2021-08-27T11:18:33Z

Codecov Report

Merging #956 (f94f106) into start-upgrade (20b564b) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           start-upgrade     #956   +/-   ##
==============================================
  Coverage          10.55%   10.55%           
==============================================
  Files                 10       10           
  Lines               1071     1071           
==============================================
  Hits                 113      113           
  Misses               953      953           
  Partials               5        5

dongsam · 2021-09-03T09:26:47Z

Cosmos-SDK v0.44.0 has been released, so will it be upgraded to based v0.44.0 instead of v0.43.0 in Gaia Vega upgrade? Then, we will also prepare for the upgrade of the liquidity module to the based v0.44.0

yaruwangway · 2021-09-03T09:38:59Z

Cosmos-SDK v0.44.0 has been released, so will it be upgraded to based v0.44.0 instead of v0.43.0 in Gaia Vega upgrade? Then, we will also prepare for the upgrade of the liquidity module to the based v0.44.0

I think so. Please confirm this @okwme
which IBC-go version will you use ?

colin-axner · 2021-09-03T10:00:37Z

which IBC-go version will you use ?

v1.1.0

alessio

Signing off. Thanks, folks 🙏

…liquidity-module-based-sdk-43 # Conflicts: # app/app.go # docs/migration/cosmoshub-6-vega-test.md # go.mod # go.sum

…liquidity-module-based-sdk-43 # Conflicts: # go.mod # go.sum

dongsam · 2021-09-07T09:28:27Z

R4R: Since the Cosmos-sdk version of #942 was updated based on v0.44.0, the liquidity was also bumped to v1.4.0 release based on sdk v0.44.0 on this PR.
As was the latest version with Gaia, import to gravity-devs/liquidity, not to tendermint/liquidity.

…liquidity-module-based-sdk-43 # Conflicts: # go.sum

CHANGELOG.md

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

* gaia upgrade prepare * app updates * app updates * Update cmd/gaiad/cmd/root.go * Update cmd/gaiad/cmd/root.go * app updates * app updates * app updates * gaia v5 to v6 * remove redundancy, change "umeeApp" to "gaiaApp" * change upgrade name from "gaia-v6.0.0" to "vega" * readme for local test * add module versions * add liquidity * add authz and fee grant * add authz and grantfee * remove ibc from storeUpgrade * change upgrade readme * upgrade readme modify * use a created validator * change validator * Bump liquidity module to v1.3.0 based sdk v0.43.0 * docs: update changelog for liquidity * build: bump liquidity version to v1.4.0 * docs: update CHANGELOG.md * docs: lint CHANGELOG.md Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: yaruwang <yaruwang.materials@gmail.com> Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> Co-authored-by: kogisin <jaybkim2@gmail.com>

* gaia upgrade prepare * app updates * app updates * app updates * Update cmd/gaiad/cmd/root.go * Update cmd/gaiad/cmd/root.go * gaia v5 to v6 * app updates * app updates * remove redundancy, change "umeeApp" to "gaiaApp" * change upgrade name from "gaia-v6.0.0" to "vega" * readme for local test * add module versions * add liquidity * add authz and fee grant * add authz and grantfee * remove ibc from storeUpgrade * change upgrade readme * upgrade readme modify * use a created validator * change validator * readme: upgrade by cosmosvisor * rebase update go.mod * sdk v0.44.0, ibc v1.1.0, liquidity v1.4.0 * add go.sum tendermint entry * seal capabilityKeeper * move local test readme to vega-test repo. * add ibc ante handler * tendermint 0.34.12 to 0.34.13 * change back tendermint version to v0.34.12 * Bump liquidity module v1.4.0 based sdk v0.44.0 (#956) * gaia upgrade prepare * app updates * app updates * Update cmd/gaiad/cmd/root.go * Update cmd/gaiad/cmd/root.go * app updates * app updates * app updates * gaia v5 to v6 * remove redundancy, change "umeeApp" to "gaiaApp" * change upgrade name from "gaia-v6.0.0" to "vega" * readme for local test * add module versions * add liquidity * add authz and fee grant * add authz and grantfee * remove ibc from storeUpgrade * change upgrade readme * upgrade readme modify * use a created validator * change validator * Bump liquidity module to v1.3.0 based sdk v0.43.0 * docs: update changelog for liquidity * build: bump liquidity version to v1.4.0 * docs: update CHANGELOG.md * docs: lint CHANGELOG.md Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: yaruwang <yaruwang.materials@gmail.com> Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> Co-authored-by: kogisin <jaybkim2@gmail.com> * make upgrade name const * use module manager to form fromVM map * gaia upgrade prepare * app updates * app updates * app updates * app updates * app updates * remove redundancy, change "umeeApp" to "gaiaApp" * change upgrade name from "gaia-v6.0.0" to "vega" * readme for local test * change upgrade readme * upgrade readme modify * use a created validator * change validator * readme: upgrade by cosmosvisor * rebase update go.mod * sdk v0.44.0, ibc v1.1.0, liquidity v1.4.0 * move local test readme to vega-test repo. * tendermint 0.34.12 to 0.34.13 * change back tendermint version to v0.34.12 * Bump liquidity module v1.4.0 based sdk v0.44.0 (#956) * gaia upgrade prepare * app updates * app updates * Update cmd/gaiad/cmd/root.go * Update cmd/gaiad/cmd/root.go * app updates * app updates * app updates * gaia v5 to v6 * remove redundancy, change "umeeApp" to "gaiaApp" * change upgrade name from "gaia-v6.0.0" to "vega" * readme for local test * add module versions * add liquidity * add authz and fee grant * add authz and grantfee * remove ibc from storeUpgrade * change upgrade readme * upgrade readme modify * use a created validator * change validator * Bump liquidity module to v1.3.0 based sdk v0.43.0 * docs: update changelog for liquidity * build: bump liquidity version to v1.4.0 * docs: update CHANGELOG.md * docs: lint CHANGELOG.md Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: yaruwang <yaruwang.materials@gmail.com> Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> Co-authored-by: kogisin <jaybkim2@gmail.com> * app: update AnteHandler * lint++ * lint++ * update VM versions * lint++ * tendermint version change to 0.34.13 * lint++ * auth migration 1 -> 2 * clean todo from vega start-upgrade * chore: update changelog * bump ibc to v1.2.0 * rebase change * rebase again * auth module version change back to 1 * change log Co-authored-by: yaruwang <yaruwang.materials@gmail.com> Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> Co-authored-by: dongsam <dongsamb@gmail.com> Co-authored-by: kogisin <jaybkim2@gmail.com>

yaruwangway and others added 23 commits August 16, 2021 17:13

gaia upgrade prepare

b08566f

app updates

5847ce2

app updates

70e8024

Update cmd/gaiad/cmd/root.go

142c460

Update cmd/gaiad/cmd/root.go

b72b004

app updates

210e042

Merge branch 'start-upgrade' of github.com:cosmos/gaia into start-upg…

81f9700

…rade

app updates

0bb8c39

app updates

4ea63ad

gaia v5 to v6

347ebe7

Merge branch 'start-upgrade' of github.com:cosmos/gaia into start-upg…

4a1fcd3

…rade

remove redundancy, change "umeeApp" to "gaiaApp"

33bb50a

change upgrade name from "gaia-v6.0.0" to "vega"

bc7dafa

readme for local test

48d0d17

add module versions

6b7056c

add liquidity

9655255

add authz and fee grant

22d1396

add authz and grantfee

2ac03cc

remove ibc from storeUpgrade

d025327

change upgrade readme

50e320b

upgrade readme modify

89a28d8

use a created validator

f6a0e3c

change validator

6df0921

dongsam mentioned this pull request Aug 27, 2021

V1: Porting to based sdk v0.43.0 and v0.44.0 for vega upgrade tendermint/liquidity#432

Closed

27 tasks

Bump liquidity module to v1.3.0 based sdk v0.43.0

eb9ebda

dongsam force-pushed the upgrade-liquidity-module-based-sdk-43 branch from 6b860ae to eb9ebda Compare August 31, 2021 02:40

dongsam marked this pull request as ready for review August 31, 2021 02:59

dongsam requested review from alessio and alexanderbez as code owners August 31, 2021 02:59

dongsam requested review from jgimeno, yaruwangway and zmanian as code owners August 31, 2021 02:59

dongsam mentioned this pull request Aug 31, 2021

Bump Cosmos SDK and ibc-go #942

Merged

16 tasks

alexanderbez approved these changes Aug 31, 2021

View reviewed changes

colin-axner approved these changes Aug 31, 2021

View reviewed changes

alessio approved these changes Sep 3, 2021

View reviewed changes

yaruwangway force-pushed the start-upgrade branch from 6df0921 to 487cdf7 Compare September 3, 2021 14:02

dongsam added 2 commits September 6, 2021 19:02

Merge commit '487cdf76397baa39cebfa1f49611b744583d3d58' into upgrade-…

4e2eb77

…liquidity-module-based-sdk-43 # Conflicts: # app/app.go # docs/migration/cosmoshub-6-vega-test.md # go.mod # go.sum

docs: update changelog for liquidity

f04ce3a

jgimeno approved these changes Sep 6, 2021

View reviewed changes

dongsam changed the title ~~Bump liquidity module based sdk v0.43.0~~ Bump liquidity module v1.4.0 based sdk v0.44.0 Sep 7, 2021

jaybxyz added 3 commits September 7, 2021 18:11

Merge commit '15c26fb2aefabd42159e97100c3f6092d473fc70' into upgrade-…

114948d

…liquidity-module-based-sdk-43 # Conflicts: # go.mod # go.sum

build: bump liquidity version to v1.4.0

727139f

docs: update CHANGELOG.md

a20585a

Merge commit '20b564b72569da1a13893dc71194730253efd412' into upgrade-…

892d9dc

…liquidity-module-based-sdk-43 # Conflicts: # go.sum

alexanderbez approved these changes Sep 9, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

docs: lint CHANGELOG.md

f94f106

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

yaruwangway merged commit fb20e65 into cosmos:start-upgrade Sep 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump liquidity module v1.4.0 based sdk v0.44.0 #956

Bump liquidity module v1.4.0 based sdk v0.44.0 #956

dongsam commented Aug 27, 2021 •

edited

Loading

codecov bot commented Aug 27, 2021 •

edited

Loading

dongsam commented Sep 3, 2021

yaruwangway commented Sep 3, 2021

colin-axner commented Sep 3, 2021

alessio left a comment

dongsam commented Sep 7, 2021 •

edited

Loading

Bump liquidity module v1.4.0 based sdk v0.44.0 #956

Bump liquidity module v1.4.0 based sdk v0.44.0 #956

Conversation

dongsam commented Aug 27, 2021 • edited Loading

Description

Liquidity module v1.3.0 is released tendermint/liquidity#439 ( discontinued due to sdk v0.44.0 released )

CHANGELOGS

Liquidity module v1.4.0 is released, gravity-devs/liquidity v1.4.0 as well

CHANGELOGS

codecov bot commented Aug 27, 2021 • edited Loading

Codecov Report

dongsam commented Sep 3, 2021

yaruwangway commented Sep 3, 2021

colin-axner commented Sep 3, 2021

alessio left a comment

Choose a reason for hiding this comment

dongsam commented Sep 7, 2021 • edited Loading

dongsam commented Aug 27, 2021 •

edited

Loading

codecov bot commented Aug 27, 2021 •

edited

Loading

dongsam commented Sep 7, 2021 •

edited

Loading