Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: Proof of concept of using our own ED25519 keys #7343

Merged
merged 0 commits into from
Sep 21, 2020

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented Sep 18, 2020

Description

  • create our own proto type ED25519
  • Inner Key field is []byte
  • Copy ed25519 files from Tendermint
  • implement crypto.PubKey on the proto struct

Workarounds added:

  • We register, in Amino, both TM's ed25519 and our own proto ed25519
  • Added a AsTmPubKey() method on the proto type, to convert our own ed25519 into TM's ed25519. Where TM expects a TM ed25519 (e.g. the tmtypes.NewValidator() function), we need to make sure to pass in pubkey.AsTmPubKey()
  • Added a workaround for bech32ifying ed25519 keys.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #7343 into marie/6928-baseacc-pk will decrease coverage by 0.65%.
The diff coverage is 25.00%.

@@                    Coverage Diff                    @@
##           marie/6928-baseacc-pk    #7343      +/-   ##
=========================================================
- Coverage                  58.07%   57.41%   -0.66%     
=========================================================
  Files                        461      421      -40     
  Lines                      30820    26032    -4788     
=========================================================
- Hits                       17898    14947    -2951     
+ Misses                     11359     9652    -1707     
+ Partials                    1563     1433     -130     

@amaury1093 amaury1093 changed the base branch from marie/6928-baseacc-pk to master September 18, 2020 13:11
@amaury1093 amaury1093 changed the base branch from master to marie/6928-baseacc-pk September 18, 2020 13:16
@amaury1093 amaury1093 merged commit 423b370 into marie/6928-baseacc-pk Sep 21, 2020
@amaury1093 amaury1093 deleted the am-own-ed25519 branch September 21, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants