Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/distribution/simulation/operations.go: add unit tests #6764

Merged
merged 6 commits into from
Jul 20, 2020

Conversation

dauTT
Copy link
Contributor

@dauTT dauTT commented Jul 17, 2020

Description

closes a sub-task related to issue #5007


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #6764 into master will increase coverage by 0.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6764      +/-   ##
==========================================
+ Coverage   60.27%   60.74%   +0.46%     
==========================================
  Files         513      513              
  Lines       31508    31508              
==========================================
+ Hits        18993    19140     +147     
+ Misses      11068    10906     -162     
- Partials     1447     1462      +15     

@dauTT dauTT mentioned this pull request Jul 18, 2020
8 tasks
@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 19, 2020
@mergify mergify bot merged commit 2247465 into cosmos:master Jul 20, 2020
chengwenxi pushed a commit to irisnet/cosmos-sdk that referenced this pull request Jul 22, 2020
* x/distribution/simulation/operations.go: add unit tests

* Use NewDecCoins constructor instead of the DecCoins struct

* Refactor code to use a testing suite

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants