-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New ADR 025 for passive channels #6250
Conversation
@michaelfig Can you rename this to a nonconflicting ADR number (i think 025 is the lowest available). 023 is already in use here by this WIP ADR: #6083 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @michaelfig. Concept ACK. It'd be great to have a bit more context by adding a few examples to ease the implementation process. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is much clearer now, still a few questions on defaults and motivation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, but let's change to a default implementation instead of a alternative call path
@Mergifyio refresh |
Command |
@michaelfig could you update to master or allow modifications |
Updated to master. I don't know where to allow modifications, though. |
@Mergifyio refresh |
Command |
seems like you need to update to master again. here is how you can allow modifications https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork and then we dont have to keep pinging you to update the pr |
Updated.
I created this PR from an organization (agoric-labs) instead of my user account (michaelfig), so this option is not presented to me. Unfortunate, but apparently Github does not support that configuration... I guess they don't imagine orgs contributing to other orgs. |
@michaelfig is not allowed to run commands |
Description
This ADR is a proposal to enable "passive" IBC relayers (ones that manage a whole connection and detect when channels come and go), as well as an "attempt channel try open" callback to allow an application to decide how and whether to handle inbound channel open handshakes.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer