Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleted concepts, moved tx-lifecycle #4739

Merged
merged 4 commits into from
Aug 7, 2019
Merged

Conversation

glozow
Copy link
Contributor

@glozow glozow commented Jul 18, 2019

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #4739 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4739      +/-   ##
==========================================
+ Coverage    54.3%   54.31%   +0.01%     
==========================================
  Files         271      271              
  Lines       17344    17344              
==========================================
+ Hits         9418     9420       +2     
+ Misses       7228     7226       -2     
  Partials      698      698

@fedekunze fedekunze added T:Docs Changes and features related to documentation. R4R labels Jul 23, 2019
@colin-axner
Copy link
Contributor

@alexanderbez any chance we can cherry-pick this into final release if its merged in time. The current master docs have merge conflicts in them and the tail of the diff is being interpreted as a markdown character making it hard to read

@alexanderbez
Copy link
Contributor

Oof I wish I saw this earlier. I don't think we can get it in for v0.36.0, but we can get it in for v0.36.1 (assuming it's not breaking).

@alexanderbez alexanderbez merged commit ddf0e6f into master Aug 7, 2019
@alexanderbez alexanderbez deleted the gloria/delete-concepts branch August 7, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants