Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: x/auth: fetch one account after another #3121

Merged
merged 2 commits into from
Dec 18, 2018
Merged

R4R: x/auth: fetch one account after another #3121

merged 2 commits into from
Dec 18, 2018

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Dec 14, 2018 •
edited
Loading

  • Don't read all accounts in one go as signature verification
    could fail before last signature is checked.

  • TestAnteHandlerFees now checks whether fees were actually
    deducted from the account as well as the fee keeper collected
    them.

Thanks: @ValarDragon for pointing this out
Closes: #3093

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Dec 14, 2018 •
edited
Loading

Codecov Report

Merging #3121 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #3121      +/-   ##
===========================================
- Coverage    55.03%   55.02%   -0.02%     
===========================================
  Files          133      133              
  Lines         9434     9434              
===========================================
- Hits          5192     5191       -1     
- Misses        3925     3926       +1     
  Partials       317      317

@alessio alessio force-pushed the alessio/3093-dont-fetch-all-accounts-in-batch branch from 97f85b1 to 16465c5 Compare December 14, 2018 11:36
@alessio alessio changed the title x/auth: fetch one account after another R4R: x/auth: fetch one account after another Dec 14, 2018
@alessio alessio force-pushed the alessio/3093-dont-fetch-all-accounts-in-batch branch from 94eade9 to e2296f9 Compare December 14, 2018 12:01
alexanderbez
alexanderbez approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small remark, but otherwise this LGTM 👌

@alessio
Copy link
Contributor Author

alessio commented Dec 14, 2018

@alexanderbez amended

cwgoes
cwgoes approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

@jackzampolin jackzampolin mentioned this pull request Dec 17, 2018
Closed
Alessio Treglia added 2 commits December 18, 2018 12:24
x/auth: fetch one account after another
badae30 
- Don't read all accounts in one go as signature verification
  could fail before last signature is checked.

- TestAnteHandlerFees now checks whether fees were actually
  deducted from the account as well as the fee keeper collected
  them.

Thanks: @ValarDragon for pointing this out
Closes: #3093
x/auth: fetch one account after another
e4ac290 
- Don't read all accounts in one go as signature verification
  could fail before last signature is checked.

- TestAnteHandlerFees now checks whether fees were actually
  deducted from the account as well as the fee keeper collected
  them.

Thanks: @ValarDragon for pointing this out
Closes: #3093
@alessio alessio force-pushed the alessio/3093-dont-fetch-all-accounts-in-batch branch from 08b66d6 to e4ac290 Compare December 18, 2018 11:29
@cwgoes cwgoes mentioned this pull request Dec 18, 2018
Closed
7 tasks
@cwgoes cwgoes merged commit 711a22f into develop Dec 18, 2018
@cwgoes cwgoes deleted the alessio/3093-dont-fetch-all-accounts-in-batch branch December 18, 2018 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@cwgoes cwgoes cwgoes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@ValarDragon ValarDragon Awaiting requested review from ValarDragon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alessio @alexanderbez @cwgoes @jackzampolin