Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decimal: Add a method to multiply a decimal by an Int. #2408

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

ValarDragon
Copy link
Contributor

This is for usage within the slash function, to minimize operations
required to slash each unbonded and redelegating account.

closes #2407

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

Merging #2408 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop    #2408   +/-   ##
========================================
  Coverage    62.97%   62.97%           
========================================
  Files          121      121           
  Lines         7271     7271           
========================================
  Hits          4579     4579           
  Misses        2374     2374           
  Partials       318      318

This is for usage within the slash function, to minimize operations
required to slash each unbonded and redelegating account.
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit e11c52e into develop Sep 26, 2018
@cwgoes cwgoes deleted the dev/decimal_mulInt branch September 26, 2018 10:13
@alexanderbez
Copy link
Contributor

Sweet! This will be useful for #2400 -- thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create decimal.MulInt
3 participants