-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
link to DOCS_README #2341
link to DOCS_README #2341
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2341 +/- ##
========================================
Coverage 65.08% 65.08%
========================================
Files 135 135
Lines 8404 8404
========================================
Hits 5470 5470
Misses 2573 2573
Partials 361 361 |
|
||
## Consistency | ||
|
||
Because the build processes are identical (as is the information contained herein), this file should be kept in sync as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to make this one file in https://github.com/tendermint/coding to avoid getting out of sync?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mhm not really. they have sight differences (links) and it's nice to have it in each repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This PR will be a duplicate of tendermint/tendermint#2398 and for the sake of consistency (last section) lets have the review in one place. I'll update this PR with the correct links and wording, after review of the PR in tendermint