Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link to DOCS_README #2341

Merged
merged 2 commits into from
Sep 19, 2018
Merged

link to DOCS_README #2341

merged 2 commits into from
Sep 19, 2018

Conversation

zramsay
Copy link
Contributor

@zramsay zramsay commented Sep 14, 2018

This PR will be a duplicate of tendermint/tendermint#2398 and for the sake of consistency (last section) lets have the review in one place. I'll update this PR with the correct links and wording, after review of the PR in tendermint

@codecov
Copy link

codecov bot commented Sep 19, 2018

Codecov Report

Merging #2341 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2341   +/-   ##
========================================
  Coverage    65.08%   65.08%           
========================================
  Files          135      135           
  Lines         8404     8404           
========================================
  Hits          5470     5470           
  Misses        2573     2573           
  Partials       361      361


## Consistency

Because the build processes are identical (as is the information contained herein), this file should be kept in sync as
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to make this one file in https://github.com/tendermint/coding to avoid getting out of sync?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mhm not really. they have sight differences (links) and it's nice to have it in each repo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cwgoes cwgoes merged commit 1167e07 into develop Sep 19, 2018
@cwgoes cwgoes deleted the zach/how-docs-work branch September 19, 2018 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants