fix(systemtests): align halt-height with comet in upgrade

[mmsqe]

Description

Closes: #XXXX

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• Tests
  • Updated system test configuration for chain upgrade
  • Modified halt height parameter from --halt-height to --comet.halt-height

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request introduces a minor modification in the TestChainUpgrade function within the system tests. The change updates the command-line argument used to specify the halt height when starting a chain during an upgrade test. The parameter has been modified from --halt-height to --comet.halt-height, which suggests an update in how the halt height is configured, likely related to CometBFT integration or configuration changes.

Changes

File	Change Summary
tests/systemtests/upgrade_test.go	Updated chain start command argument from --halt-height to --comet.halt-height

Possibly related PRs

• fix(simapp,systemtests): fix chain upgrade #22669: Modification of TestChainUpgrade function in the same file
• test(systemtests): fix gRPC tests for v1 & v2 #22774: Changes to tests/systemtests/upgrade_test.go addressing upgrade process

Suggested labels

C:server/v2, C:server/v2 cometbft

Suggested reviewers

• kocubinski
• facundomedica
• hieuvubk
• tac0turtle

---

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 517839b and 34e2da4.

📒 Files selected for processing (1)

• tests/systemtests/upgrade_test.go (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

tests/systemtests/upgrade_test.go (3)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

---

Pattern tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"

---

Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: tests (00)
• GitHub Check: test-simapp-v2
• GitHub Check: test-integration
• GitHub Check: test-system-v2
• GitHub Check: Analyze
• GitHub Check: build (amd64)
• GitHub Check: Summary

🔇 Additional comments (2)

tests/systemtests/upgrade_test.go (2)

Line range hint 1-115: Test coverage assessment: Comprehensive upgrade flow testing.

The test provides excellent coverage of the upgrade scenario:

1. Initializes with a legacy chain (v0.52.0-beta.3)
2. Submits and validates upgrade proposal
3. Verifies upgrade at the specified height
4. Confirms successful chain restart with new version
5. Includes smoke tests for new functionality

The test structure follows best practices with:

• Clear setup and teardown
• Proper error handling
• Appropriate timeouts
• Verification steps

---

43-43: LGTM! Command-line argument updated to align with CometBFT configuration.

The change from --halt-height to --comet.halt-height correctly aligns the configuration with CometBFT's parameter naming convention.

Let's verify if this parameter is consistently used across the codebase:

✅ Verification successful

Parameter rename is correctly implemented and consistent

The change from --halt-height to --comet.halt-height is part of a systematic update of CometBFT-related parameters. The codebase handles this consistently with:

• Automatic parameter migration in the configuration system
• Preserved internal parameter names for stability
• Updated CLI interface across the codebase

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any remaining instances of the old parameter
rg --type go "halt-height" -g '!tests/systemtests/upgrade_test.go'

# Search for the new parameter to ensure consistency
rg --type go "comet.halt-height"

Length of output: 1110

---

Script:

#!/bin/bash
# Check the migration implementation
ast-grep --pattern 'func $_($$_) {
  $$$
  "halt-height"
  $$$
}'

Length of output: 67

---

Script:

#!/bin/bash
# Check the migrations file content with context
rg --type go -C 5 '"halt-height"' tools/confix/migrations.go

Length of output: 587

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[julienrbrt]

ACK! In the backport we can add a if V2() for it.