Add optional flag to gaiad testnet to make config directory of daemon…
#1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on and cli configurable, fixes cosmos#1992
philipstanislaus
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Closed
4 tasks
Codecov Report
@@ Coverage Diff @@
## develop #1993 +/- ##
===========================================
- Coverage 63.95% 60.57% -3.39%
===========================================
Files 140 119 -21
Lines 8695 6924 -1771
===========================================
- Hits 5561 4194 -1367
+ Misses 2757 2491 -266
+ Partials 377 239 -138 |
ValarDragon
approved these changes
Aug 12, 2018
melekes
reviewed
Aug 14, 2018
server/testnet.go
Outdated
| outputDir = "o" | ||
| nodeDirPrefix = "node-dir-prefix" | ||
| nValidators = "v" | ||
| outputDir = "o" |
|
After fixing conflicts, this seems good to merge imo |
|
@philipstanislaus Thanks for the PR, sorry this took us so long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and cli configurable, fixes #1992
docs/) => documented through cobra cli docsPENDING.mdthat include links to the relevant issue or PR that most accurately describes the change.cmd/gaiaandexamples/For Admin Use: