feat(server/v2): router service #19696

julienrbrt · 2024-03-08T08:21:21Z

Description

Closes: #19542, #19324

Blocked on #20320

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

included the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
targeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to CHANGELOG.md
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed all author checklist items have been addressed
reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

coderabbitai · 2024-03-08T08:21:26Z

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

server/v2/stf/core_router_service.go

github-actions · 2024-04-08T00:05:37Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

julienrbrt · 2024-04-08T09:21:44Z

not stale, just blocked

julienrbrt · 2024-04-08T09:32:30Z

I suppose this is still blocked on this eventhough we don't go with hybrid handler: #19639 correct? cc @testinginprod

server/v2/stf/core_router_service.go

+// Use InvokeUntyped if the response type is not known.
+func (m *msgRouterService) InvokeTyped(ctx context.Context, msg, resp protoiface.MessageV1) error {
+	var err error
+	resp, err = m.handler(ctx, msg)


server/v2/stf/core_router_service.go

+// Use InvokeUntyped if the response type is not known.
+func (m *queryRouterService) InvokeTyped(ctx context.Context, req, resp protoiface.MessageV1) error {
+	var err error
+	resp, err = m.handler(ctx, req)


github-actions · 2024-05-06T15:43:47Z

@julienrbrt your pull request is missing a changelog!

runtime/v2/module.go

kocubinski · 2024-05-08T13:39:21Z

runtime/v2/module.go

@@ -275,6 +275,7 @@ func ProvideEnvironment(logger log.Logger, config *runtimev2.Module, key depinje
 		EventService:    stf.NewEventService(),
 		GasService:      stf.NewGasMeterService(),
 		HeaderService:   stf.HeaderService{},
+		RouterService:   stf.NewRouterService(kvService, app.app.queryRouterBuilder, app.app.msgRouterBuilder),


Would it be cleaner to just place MessageRouterService and QueryRouterService as fields on Environment instead of nesting them behind a getter in RouterService?

Something we should do consistently on main afterwards given we have the same on main.

makes senes to me i shall flag a TODO

testinginprod

LGTM

tac0turtle · 2024-05-09T11:37:06Z

should we make this against main since stf is there now

kocubinski · 2024-05-09T14:41:54Z

should we make this against main since stf is there now

idtso, it's part of the runtime/v2 PR (branch its targeting now)

…ulien/runtimev2-service

Base automatically changed from julien/simplify-serverv2 to server_modular March 8, 2024 09:42

julienrbrt force-pushed the julien/runtimev2-service branch from aceeae3 to dfd0041 Compare March 8, 2024 09:45

0x2d3c reviewed Mar 8, 2024

View reviewed changes

server/v2/stf/core_router_service.go Outdated Show resolved Hide resolved

0x2d3c reviewed Mar 8, 2024

View reviewed changes

server/v2/stf/core_router_service.go Outdated Show resolved Hide resolved

github-actions bot added the Stale label Apr 8, 2024

julienrbrt removed the Stale label Apr 8, 2024

github-advanced-security bot found potential problems Apr 25, 2024

View reviewed changes

julienrbrt marked this pull request as ready for review May 6, 2024 15:43

julienrbrt requested a review from a team as a code owner May 6, 2024 15:43

julienrbrt assigned kocubinski and testinginprod May 6, 2024

julienrbrt requested review from kocubinski and testinginprod May 6, 2024 15:43

kocubinski reviewed May 8, 2024

View reviewed changes

runtime/v2/module.go Outdated Show resolved Hide resolved

kocubinski reviewed May 8, 2024

View reviewed changes

testinginprod approved these changes May 8, 2024

View reviewed changes

chore: upstream runtime/v2

b36b6cd

julienrbrt changed the base branch from server_modular to kocu/runtime-v2 May 8, 2024 14:37

julienrbrt changed the base branch from kocu/runtime-v2 to server_modular May 8, 2024 14:37

julienrbrt force-pushed the julien/runtimev2-service branch from 78bc9cd to 8305095 Compare May 8, 2024 14:39

feat(server/v2): router service

18fca65

julienrbrt force-pushed the julien/runtimev2-service branch from 8305095 to 18fca65 Compare May 8, 2024 14:41

github-actions bot added C:x/staking C:CLI C:x/gov labels May 8, 2024

draft required TransactionService impl

1becc15

Merge branch 'kocu/runtime-v2' into julien/runtimev2-service

3b1f6a4

kocubinski approved these changes May 9, 2024

View reviewed changes

kocubinski added a commit that referenced this pull request May 9, 2024

cherry-pick #19696

20e7962

kocubinski force-pushed the kocu/runtime-v2 branch from 1becc15 to df04a11 Compare May 9, 2024 15:04

kocubinski added 2 commits May 9, 2024 10:07

Merge branch 'kocu/runtime-v2' of github.com:cosmos/cosmos-sdk into j…

3b94374

…ulien/runtimev2-service

formatting

012e3a5

julienrbrt merged commit 3debde3 into kocu/runtime-v2 May 9, 2024
56 of 58 checks passed

julienrbrt deleted the julien/runtimev2-service branch May 9, 2024 15:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(server/v2): router service #19696

feat(server/v2): router service #19696

julienrbrt commented Mar 8, 2024 •

edited

Loading

coderabbitai bot commented Mar 8, 2024 •

edited

Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Apr 8, 2024

julienrbrt commented Apr 8, 2024

julienrbrt commented Apr 8, 2024

github-actions bot commented May 6, 2024

kocubinski May 8, 2024

julienrbrt May 8, 2024

kocubinski May 8, 2024

testinginprod left a comment

tac0turtle commented May 9, 2024

kocubinski commented May 9, 2024

feat(server/v2): router service #19696

feat(server/v2): router service #19696

Conversation

julienrbrt commented Mar 8, 2024 • edited Loading

Description

Author Checklist

Reviewers Checklist

coderabbitai bot commented Mar 8, 2024 • edited Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Apr 8, 2024

julienrbrt commented Apr 8, 2024

julienrbrt commented Apr 8, 2024

github-actions bot commented May 6, 2024

kocubinski May 8, 2024

Choose a reason for hiding this comment

julienrbrt May 8, 2024

Choose a reason for hiding this comment

kocubinski May 8, 2024

Choose a reason for hiding this comment

testinginprod left a comment

Choose a reason for hiding this comment

tac0turtle commented May 9, 2024

kocubinski commented May 9, 2024

julienrbrt commented Mar 8, 2024 •

edited

Loading

coderabbitai bot commented Mar 8, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)