chore: remove mint imports in the sdk

[tac0turtle]

Description

ref ##18290

this pr moves grpc server integration tests to the integration folder and removes importing of the mint module within the cosmos sdk root

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• run make lint and make test
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

Summary by CodeRabbit

Refactor:

• Removed unused minttypes package import from baseapp/block_gas_test.go, baseapp/utils_test.go, and testutil/sims/address_helpers.go files, simplifying the codebase.
• Introduced a new constant mintModuleName to replace minttypes.ModuleName in testutil/sims/address_helpers.go, enhancing code readability.

Please note, these changes do not affect the functionality of the application and are aimed at improving the code quality and maintainability.

[coderabbitai]

Walkthrough

The changes primarily revolve around the removal of the minttypes package import across multiple files and the introduction of a new constant mintModuleName. The codebase now uses this constant instead of minttypes.ModuleName, with no significant alterations to the core structure or functionality of the code.

Changes

File Path	Summary
baseapp/block_gas_test.go	Removed minttypes import and added mintModuleName constant.
baseapp/utils_test.go	Removed import of "mint" module.
testutil/sims/.../address_helpers.go	Introduced mintModuleName constant, removed minttypes import, and updated initAccountWithCoins function to use the new constant.

Poem

🍂 As the autumn leaves fall, so does the minttypes call, 🍁

Replaced by mintModuleName, standing tall. 🏛️

No more imports, no more fuss, 🚫

Just a constant among us. 🐇

Celebrate the change, embrace the new, 🎉

CodeRabbit's here, coding with you. 🐰💻

So here's to the season, crisp and bright, 🌞

And to code that's clean, and light. 🍻

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• If you reply to a review comment from CodeRabbit, the bot will automatically respond.
• To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
• Note: Review comments are made on code diffs or files, not on the PR overview.
• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai help to get help.
• @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 15ccdcc and 619b44f.

Files selected for processing (3)

• baseapp/block_gas_test.go (3 hunks)
• baseapp/utils_test.go (1 hunks)
• testutil/sims/address_helpers.go (2 hunks)

Files skipped from review due to trivial changes (3)

• baseapp/block_gas_test.go
• baseapp/utils_test.go
• testutil/sims/address_helpers.go

[julienrbrt]

Can we remove the dep from the go.mod?

[julienrbrt]

this is grpc server test, imho we should keep the subdir in integration as well

[tac0turtle]

Can we remove the dep from the go.mod?

no because staking and bank import it, so we need to remove those or remove the dep of min in those in order to make this work.

[facundomedica]

Running go-mod-tidy-all.sh produces lots of changes locally for me, maybe it's that what's making the build fail?

[julienrbrt]

should be reverted.