Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gov): remove global bech32 #15682

Merged
merged 8 commits into from
Apr 6, 2023
Merged

refactor(gov): remove global bech32 #15682

merged 8 commits into from
Apr 6, 2023

Conversation

tac0turtle
Copy link
Member

Description

ref #13140

this pr migrates gov to use address codec, but avoids getsigners and validatebasic. Those will be handled in a different pr


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle requested a review from a team as a code owner April 3, 2023 17:45
@github-prbot github-prbot requested review from a team, alexanderbez and facundomedica and removed request for a team April 3, 2023 17:45
@julienrbrt julienrbrt changed the title refactor(gov): remove globalbec32 refactor(gov): remove global bech32 Apr 5, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 5, 2023
@julienrbrt julienrbrt enabled auto-merge (squash) April 6, 2023 08:23
@julienrbrt julienrbrt merged commit f5993b1 into main Apr 6, 2023
@julienrbrt julienrbrt deleted the marko/bech32_gov branch April 6, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/evidence C:x/gov
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants