Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth, bank, distribution, gov, staking #15645

Closed
wants to merge 1 commit into from
Closed

auth, bank, distribution, gov, staking #15645

wants to merge 1 commit into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Mar 31, 2023 •
edited
Loading

Description

works towards: #15546

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@faddat faddat requested a review from a team as a code owner March 31, 2023 04:37
@github-prbot github-prbot requested review from a team, atheeshp and likhita-809 and removed request for a team March 31, 2023 04:38
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 31, 2023
View reviewed changes
x/distribution/simulation/proposals.go
@@ -14,7 +14,7 @@
const (
DefaultWeightMsgUpdateParams int = 50

OpWeightMsgUpdateParams = "op_weight_msg_update_params" //nolint:gosec
OpWeightMsgUpdateParams = "op_weight_msg_update_params"

Check failure

Code scanning / gosec

Potential hardcoded credentials

Potential hardcoded credentials
x/auth/simulation/proposals.go
@@ -14,7 +14,7 @@
const (
DefaultWeightMsgUpdateParams int = 100

OpWeightMsgUpdateParams = "op_weight_msg_update_params" //nolint:gosec
OpWeightMsgUpdateParams = "op_weight_msg_update_params"

Check failure

Code scanning / gosec

Potential hardcoded credentials

Potential hardcoded credentials
x/distribution/simulation/operations.go
OpWeightMsgSetWithdrawAddress = "op_weight_msg_set_withdraw_address"
OpWeightMsgWithdrawDelegationReward = "op_weight_msg_withdraw_delegation_reward"
OpWeightMsgWithdrawValidatorCommission = "op_weight_msg_withdraw_validator_commission"
OpWeightMsgFundCommunityPool = "op_weight_msg_fund_community_pool"

Check failure

Code scanning / gosec

Potential hardcoded credentials

Potential hardcoded credentials
x/distribution/simulation/operations.go
OpWeightMsgWithdrawValidatorCommission = "op_weight_msg_withdraw_validator_commission" //nolint:gosec
OpWeightMsgFundCommunityPool = "op_weight_msg_fund_community_pool" //nolint:gosec
OpWeightMsgSetWithdrawAddress = "op_weight_msg_set_withdraw_address"
OpWeightMsgWithdrawDelegationReward = "op_weight_msg_withdraw_delegation_reward"

Check failure

Code scanning / gosec

Potential hardcoded credentials

Potential hardcoded credentials
x/bank/simulation/operations.go
DefaultWeightMsgSend = 100 // from simappparams.DefaultWeightMsgSend
DefaultWeightMsgMultiSend = 10 // from simappparams.DefaultWeightMsgMultiSend
OpWeightMsgSend = "op_weight_msg_send"
OpWeightMsgMultiSend = "op_weight_msg_multisend"

Check failure

Code scanning / gosec

Potential hardcoded credentials

Potential hardcoded credentials
x/staking/simulation/proposals.go
@@ -15,7 +15,7 @@
const (
DefaultWeightMsgUpdateParams int = 100

OpWeightMsgUpdateParams = "op_weight_msg_update_params" //nolint:gosec
OpWeightMsgUpdateParams = "op_weight_msg_update_params"

Check failure

Code scanning / gosec

Potential hardcoded credentials

Potential hardcoded credentials
x/distribution/simulation/operations.go
OpWeightMsgFundCommunityPool = "op_weight_msg_fund_community_pool" //nolint:gosec
OpWeightMsgSetWithdrawAddress = "op_weight_msg_set_withdraw_address"
OpWeightMsgWithdrawDelegationReward = "op_weight_msg_withdraw_delegation_reward"
OpWeightMsgWithdrawValidatorCommission = "op_weight_msg_withdraw_validator_commission"

Check failure

Code scanning / gosec

Potential hardcoded credentials

Potential hardcoded credentials
x/distribution/simulation/operations.go
OpWeightMsgWithdrawDelegationReward = "op_weight_msg_withdraw_delegation_reward" //nolint:gosec
OpWeightMsgWithdrawValidatorCommission = "op_weight_msg_withdraw_validator_commission" //nolint:gosec
OpWeightMsgFundCommunityPool = "op_weight_msg_fund_community_pool" //nolint:gosec
OpWeightMsgSetWithdrawAddress = "op_weight_msg_set_withdraw_address"

Check failure

Code scanning / gosec

Potential hardcoded credentials

Potential hardcoded credentials
x/bank/simulation/operations.go
OpWeightMsgMultiSend = "op_weight_msg_multisend" //nolint:gosec
DefaultWeightMsgSend = 100 // from simappparams.DefaultWeightMsgSend
DefaultWeightMsgMultiSend = 10 // from simappparams.DefaultWeightMsgMultiSend
OpWeightMsgSend = "op_weight_msg_send"

Check failure

Code scanning / gosec

Potential hardcoded credentials

Potential hardcoded credentials
x/bank/simulation/proposals.go
@@ -14,7 +14,7 @@
const (
DefaultWeightMsgUpdateParams int = 100

OpWeightMsgUpdateParams = "op_weight_msg_update_params" //nolint:gosec
OpWeightMsgUpdateParams = "op_weight_msg_update_params"

Check failure

Code scanning / gosec

Potential hardcoded credentials

Potential hardcoded credentials
@faddat faddat marked this pull request as draft March 31, 2023 05:01
@faddat faddat closed this Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atheeshp atheeshp Awaiting requested review from atheeshp

@likhita-809 likhita-809 Awaiting requested review from likhita-809

Assignees
No one assigned
Labels
C:Simulations C:x/auth C:x/bank C:x/distribution distribution module related C:x/gov C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@faddat