Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: linter fixes for feegrant and upgrade #15642

Merged
merged 11 commits into from
Apr 3, 2023
Merged

style: linter fixes for feegrant and upgrade #15642

merged 11 commits into from
Apr 3, 2023

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Mar 31, 2023 •
edited
Loading

Description

works towards:

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@faddat faddat requested a review from a team as a code owner March 31, 2023 04:25
@github-prbot github-prbot requested review from a team, kocubinski and alexanderbez and removed request for a team March 31, 2023 04:30
tac0turtle
tac0turtle reviewed Mar 31, 2023
View reviewed changes
@julienrbrt julienrbrt changed the title linter fixes for feegrant and upgrade style: linter fixes for feegrant and upgrade Mar 31, 2023
julienrbrt
julienrbrt reviewed Mar 31, 2023
View reviewed changes
@julienrbrt
Copy link
Member

@faddat could you implement the feedback here so we can merge :)

@faddat faddat marked this pull request as draft April 1, 2023 16:18
@faddat
Copy link
Contributor Author

faddat commented Apr 2, 2023

yep, sorry bout the delay!

@faddat faddat marked this pull request as ready for review April 2, 2023 00:39
@github-prbot github-prbot requested a review from a team April 2, 2023 00:40
@faddat
Copy link
Contributor Author

faddat commented Apr 3, 2023

okiedokie, done! Sorry bout the delay fellas

julienrbrt
julienrbrt approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. one nit.

x/feegrant/simulation/operations.go Outdated
@@ -17,7 +17,7 @@ import (

// Simulation operation weights constants
//
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove that extra //

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep!

@julienrbrt julienrbrt enabled auto-merge (squash) April 3, 2023 07:25
@julienrbrt julienrbrt merged commit bd8b01c into cosmos:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle left review comments

@julienrbrt julienrbrt julienrbrt approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
C:Simulations C:x/feegrant C:x/upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faddat @julienrbrt @tac0turtle