Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare v0.46.8 release #14624

Merged
merged 4 commits into from
Jan 23, 2023
Merged

chore: prepare v0.46.8 release #14624

merged 4 commits into from
Jan 23, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jan 14, 2023

Description

Prepare v0.46.8 release.
Add replace to point to Informal System fork of Tendermint (as per twitter.com/informalinc/status/1613580977980473346).

Changes tested against a Quicksilver node (v0.46.8-0.20230107121918-36784a8a7a93).


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner January 14, 2023 21:33
@@ -166,6 +166,8 @@ replace (
github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1

github.com/jhump/protoreflect => github.com/jhump/protoreflect v1.9.0
// use informal system fork of tendermint
github.com/tendermint/tendermint => github.com/informalsystems/tendermint v0.34.24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all chains that upgrade to v0.47 doing to have to do this as well? If so, we should reference this in the release notes & upgrading guide (if we have not already).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good one, let me add that in the release notes. We should do that for v0.45 too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this for 0.46 and 0.45? I would think not?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The replace or the mention?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the replace, we can mention it, but its also not required

Copy link
Contributor

@alexanderbez alexanderbez Jan 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any where we have a replace for Tendermint I think a chain would need a replace too because Tendermint dep is used in app-specific stuff like cmd. So updating our docs/guides will be necessary.

Copy link
Member Author

@julienrbrt julienrbrt Jan 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the advice is to use the replace given that you could rewrite git history (go.sum should detect that but still - for new chains you don't have that guarantee).

@julienrbrt julienrbrt requested a review from tac0turtle January 23, 2023 14:03
@tac0turtle tac0turtle merged commit 3a051e1 into release/v0.46.x Jan 23, 2023
@tac0turtle tac0turtle deleted the julien/0468 branch January 23, 2023 18:52
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants