-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prepare v0.46.8 release #14624
Conversation
@@ -166,6 +166,8 @@ replace ( | |||
github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1 | |||
|
|||
github.com/jhump/protoreflect => github.com/jhump/protoreflect v1.9.0 | |||
// use informal system fork of tendermint | |||
github.com/tendermint/tendermint => github.com/informalsystems/tendermint v0.34.24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all chains that upgrade to v0.47 doing to have to do this as well? If so, we should reference this in the release notes & upgrading guide (if we have not already).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good one, let me add that in the release notes. We should do that for v0.45 too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this for 0.46 and 0.45? I would think not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The replace or the mention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the replace, we can mention it, but its also not required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any where we have a replace
for Tendermint I think a chain would need a replace too because Tendermint dep is used in app-specific stuff like cmd. So updating our docs/guides will be necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the advice is to use the replace given that you could rewrite git history (go.sum should detect that but still - for new chains you don't have that guarantee).
Description
Prepare v0.46.8 release.
Add replace to point to Informal System fork of Tendermint (as per twitter.com/informalinc/status/1613580977980473346).
Changes tested against a Quicksilver node (
v0.46.8-0.20230107121918-36784a8a7a93
).Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change