fix: AuxTxBuilder check all AuxSignerData match #10547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
reviewed
Nov 16, 2021
| @@ -217,7 +217,7 @@ message Fee { | |||
| // Tip is the tip used for meta-transactions. | |||
| message Tip { | |||
| // amount is the amount of the tip | |||
| repeated cosmos.base.v1beta1.Coin amount = 1 [(gogoproto.nullable) = false]; | |||
| repeated cosmos.base.v1beta1.Coin amount = 1 [(gogoproto.nullable) = false, (gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins"]; | |||
There was a problem hiding this comment.
should we avoid using cast repeated as it seems we may stop using it later on?
nit: don't block on this
There was a problem hiding this comment.
sure... I guess we can just wrap it in Coins when needed
aaronc
approved these changes
Nov 16, 2021
tac0turtle
added
the
A:automerge
blewater
pushed a commit
to e-money/cosmos-sdk
that referenced
this pull request
Dec 8, 2021
* Rename file * Check matching AuxSignerData * Remove getbody * Remove useless code * Add small test Co-authored-by: Marko <marbar3778@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We added
AddAuxSignerDataon AuxTxBuilder. @i-norden pointed out that the fee payer could call this function multiple times (if there are multiple aux signers) but with different data.This PR adds some checks that all AuxSignerData added using
AddAuxSignerDataare the same.ref: #10455 (comment)
closes #10443
also closes #10528
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change