Fork RocksDB into cosmos organization and use it in store/v2 #10263
Comments
|
Do you need me to fork the repo under the cosmos org @robert-zaremba ? |
It would be preferred, however if you think it's not needed then we can close this task as noop. |
|
Ill try to fork into cosmos, I think it makes the most sense |
|
it has been forked. @roysc want to move over your changes? |
|
This task was supposed to port roysc changes here. So the easy way was to ask @roysc simply push his version here. Reopening until this is done, and subtasks resolved. |
|
Also, we need to set the branch protection : merges in |
|
@robert-zaremba can you clarify? what needs to be done besides updating https://github.com/cosmos/gorocksdb and the go.mod ref? |
added it, now one approval before merging |
I believe its to make the go.mod change only. |
|
yes, go.mod |
## Description Part of: #10192 Introduces a new `RootStore` type in the `store/v2` package and an implementation, without yet replacing the `MultiStore` or refactoring its use within the SDK (which will happen in the follow up: #10174). Specified by [ADR-040](https://github.com/cosmos/cosmos-sdk/blob/1326fa2a7dfc3d83cf23dc1c1f33ff131152ad60/docs/architecture/adr-040-storage-and-smt-state-commitments.md). Fixes #10651 Fixes #10263 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
Summary
We need a patch in RocksDB created by @roysc . Since Cosmos ecosystem is very active, we want to have a direct access to all dependencies we modify.
Ref: #9851 (comment)
cosmos/rocksdbdb/go.modto use cosmos fork.CC: @i-norden , @roysc
For Admin Use
The text was updated successfully, but these errors were encountered: