Simplify context (#4706)

Replace complex Context construct with a simpler immutible struct. Only breaking change is not to support `Value` and `GetValue` as first class calls. We do embed ctx.Context() as a raw context.Context instead to be used as you see fit.
cosmos · Jul 16, 2019 · d3bb9f5 · d3bb9f5
1 parent 6ca6418
commit d3bb9f5
Show file tree

Hide file tree

Showing 3 changed files with 191 additions and 284 deletions.
diff --git a/.pending/improvements/sdk/4706-Simplify-context b/.pending/improvements/sdk/4706-Simplify-context
@@ -0,0 +1,11 @@
+4706 - Simplify context
+
+Replace complex Context construct with a simpler immutible struct.
+Only breaking change is not to support `Value` and `GetValue` as first class calls.
+We do embed ctx.Context() as a raw context.Context instead to be used as you see fit.
+
+Migration guide:
+`ctx = ctx.WithValue(contextKeyBadProposal, false)` ->
+`ctx = ctx.WithContext(context.WithValue(ctx.Context(), contextKeyBadProposal, false))`
+A bit more verbose, but also allows `context.WithTimeout()`, etc and only used
+in one function in this repo, in test code.