Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename n contacts to cumulative contact duration in agents.py #256

Merged
merged 2 commits into from
Jun 12, 2021

Conversation

mreveil
Copy link
Contributor

@mreveil mreveil commented Jun 11, 2021

The n_contacts property in agent.py is misleading. It doesn't actually count the number of contacts as it is incremented every step the agent is within contact distance of another agent. The name is changed to cumulative_contact_duration to better match what it actually represents.

@mreveil mreveil linked an issue Jun 11, 2021 that may be closed by this pull request
@mreveil mreveil requested a review from amjha June 11, 2021 21:26
@amjha amjha merged commit 349946c into main Jun 12, 2021
@amjha amjha deleted the rename_n_contacts_property branch June 12, 2021 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change or relabel the number of contacts property in agent class
2 participants