This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
api: implement query parameters #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,13 +62,23 @@ func (sr *stateResource) list(rw http.ResponseWriter, req *http.Request) { | |||
| sendResponse(rw, http.StatusOK, &page) | |||
| } | |||
|
|
|||
| func getUnitStatePage(cAPI client.API, tok PageToken) (*schema.UnitStatePage, error) { | |||
| func getUnitStatePage(cAPI client.API, machineID, unitName string, tok PageToken) (*schema.UnitStatePage, error) { | |||
| states, err := cAPI.UnitStates() | |||
There was a problem hiding this comment.
Turns out cAPI.UnitStates(name) doesn't exist as I thought it already did... Will come back and implement it later as an optimization
|
@jonboulle LGTM |
jonboulle
added a commit
that referenced
this pull request
Aug 27, 2014
api: implement query parameters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query parameters here need to be implemented.