This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
global units: do some agent-level validation #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also related: #494 |
jonboulle
force-pushed
the
811_agent_global_validation
branch
3 times, most recently
from
e0fa603 to
ebd69fa
Compare
| @@ -126,6 +127,11 @@ func desiredAgentState(a *Agent, reg registry.Registry) (*AgentState, error) { | |||
|
|
|||
| for _, u := range units { | |||
| u := u | |||
| md := u.RequiredTargetMetadata() | |||
| if u.IsGlobal() && !machine.HasMetadata(&ms, md) { | |||
| log.Infof("Agent unable to run global unit %s: missing required metadata %v", u.Name, md) | |||
There was a problem hiding this comment.
md in the output is actually going to be a potentially cumbersome map. If you want to log this, we should first be able to identify what specific key caused the mismatch.
There was a problem hiding this comment.
... and this probably should not be logged at Infof. How about V(1).Infof?
There was a problem hiding this comment.
I am just going to omit it because HasMetadata already does its own verbose logging.
jonboulle
force-pushed
the
811_agent_global_validation
branch
from
14ac320 to
ca6464e
Compare
|
Updated |
| } | ||
|
|
||
| func TestDesiredAgentState(t *testing.T) { | ||
| testCases := []struct { |
|
LGTM |
jonboulle
added a commit
that referenced
this pull request
Sep 2, 2014
global units: do some agent-level validation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When launching global units, the agent should perform a minimal amount of validation to ensure it can actually run the unit. This should probably be nothing more than checking for metadata requirements. Specifically, any other kind of scheduling requirements (like Peers or Conflicts) are NOT supported.
Related: #659