This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Stop making unnecessary requests to etcd #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove two unnecessary etcd requests by using the data that is already available on the Job model passed to determineJobState.
|
ok lgtm |
bcwaldon
added a commit
that referenced
this pull request
Aug 5, 2014
Stop making unnecessary requests to etcd
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly fixes #733. It takes the number of requests down in the EtcdRegistry.Jobs() codepath from 7N+3 to 2N+3 (where N is # jobs). The remaining 2N can still be simplified down to a constant 2, but I do not want to conflict with any of the work being done by @jonboulle right now.