This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Panic during fleetctl submit (in (r *EtcdRegistry) storeOrGetUnit) #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bcwaldon shouldn't |
|
on looking at it closer, I guess not - we just need to be more careful about type assertions |
| @@ -225,9 +225,7 @@ func (r *EtcdRegistry) GetJobTargetState(jobName string) (*job.JobState, error) | |||
| } | |||
| resp, err := r.etcd.Do(&req) | |||
| if err != nil { | |||
| if err.(etcd.Error).ErrorCode != etcd.ErrorNodeExist { | |||
There was a problem hiding this comment.
Yeah, not sure why this was here.
|
lgtm |
jonboulle
added a commit
that referenced
this pull request
Jun 20, 2014
fix panic during type assertion in storeOrGetUnit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I run
fleetctl submit path/to/my.service, I get the following panic stacktrace, from registry/unit.go line 34 (which is line 37 in the stack trace after I added a call to log.Errorf):This is with a client fleetctl at commit 8c37793 hitting a server on CoreOS 349.0.0 (alpha).
If I add a log.Errorf call, the err that is causing the panic is:
My etcd cluster backing fleet appears to be in a bad state (1 out of 3 nodes has dropped inexplicably), which may be causing this issue. But this line of code should maybe be patched to not assume only a certain error type.
Other info:
go version go1.3 linux/amd64Linux qq 3.11.0-23-generic #40-Ubuntu SMP Wed Jun 4 21:05:23 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux