This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
functional: poweroff machine using machinectl instead of systemctl #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't remember why we couldn't use this in the first place - but this LGTM if the tests pass. |
So far ReplaceMember has been checking for error, by looking up an
explicit string "Success" in stderr from "systemctl -M <ID> poweroff".
However, with systemd v229 or newer, systemctl poweroff does not print
out "Success" even if poweroff succeeded. This causes
TestKnownHostsVerification to always return error like:
--- FAIL: TestKnownHostsVerification (2.66s)
client_test.go:60: Failed replacing machine: poweroff failed:
Fix it by changing the systemctl call to "machinectl poweroff <ID>",
which should return error correctly. This would be better in the long
run, than checking for messages in stderr.
Fixes: coreos#1586
dongsupark
force-pushed
the
dongsu/poweroff-check-error-fxtests
branch
from
bc2844a to
81c220a
Compare
|
Yesterday I did a minor update by changing error message. Functional tests also passed. I'll merge it soon. |
|
Merged #1587. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far
ReplaceMemberhas been checking for error, by looking up an explicit string"Success"in stderr from"systemctl -M <ID> poweroff". However, with systemd v229 or newer, systemctl poweroff does not print out"Success"even if poweroff succeeded. This causesTestKnownHostsVerificationto always return error like:Fix it by changing the systemctl call to
"machinectl poweroff <ID>", which should return error correctly. This would be better in the long run, than checking for messages in stderr.Fixes: #1586