Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

fleet must fail on startup if it cannot read /etc/machine-id #420

Closed
bcwaldon opened this issue May 8, 2014 · 3 comments
Closed

fleet must fail on startup if it cannot read /etc/machine-id #420

bcwaldon opened this issue May 8, 2014 · 3 comments
Assignees
@bcwaldon
Milestone
v0.3.1

Comments

@bcwaldon
Copy link
Contributor

bcwaldon commented May 8, 2014

machine.readLocalMachineID returns an empty string if it fails reading /etc/machine-id. fleet cannot operate without this value. It is better to prevent fleet from starting up altogether if a zero-length value is loaded as the ID.
@bcwaldon bcwaldon added the bug label May 8, 2014
@linuxy
Copy link

linuxy commented May 8, 2014

Perhaps a useful failover could be $HOSTNAME or a hash thereof.

@philips
Copy link
Contributor

philips commented May 8, 2014

@linuxy where are you running systemd that doesn't have a /etc/machine-id ? We should stop and tell the user to run systemd-machine-id-setup

@linuxy
Copy link

linuxy commented May 8, 2014

I have a bad habit of rolling my own OSs. In this case a Debian Jessie live-boot (PXE) based environment.

@bcwaldon bcwaldon self-assigned this May 8, 2014
@bcwaldon bcwaldon added this to the v0.3.1 milestone May 8, 2014
bcwaldon added a commit to bcwaldon/fleet that referenced this issue May 9, 2014
@bcwaldon
fix(server): Fail startup if machind ID undetectable
246fcba 
Fix coreos#420
bcwaldon added a commit that referenced this issue May 9, 2014
@bcwaldon
Merge pull request #422 from bcwaldon/420
c0a62dc 
Fix #420 & refactor machine.New
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcwaldon bcwaldon

Labels
None yet
Projects
None yet
Milestone
v0.3.1
Development

No branches or pull requests
3 participants
@philips @bcwaldon @linuxy