Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Master does not build (fleetctl) on GOOS=darwin #1603

Closed
ewoutp opened this issue Jun 12, 2016 · 2 comments · Fixed by #1604
Closed

Master does not build (fleetctl) on GOOS=darwin #1603

ewoutp opened this issue Jun 12, 2016 · 2 comments · Fixed by #1604
Labels
component/fleetctl dependency/external kind/regression

Comments

@ewoutp
Copy link
Contributor

ewoutp commented Jun 12, 2016 

$ ./build
Not on Linux - skipping fleetd build
Building fleetctl...
# github.com/coreos/fleet/vendor/github.com/vishvananda/netlink
gopath/src/github.com/coreos/fleet/vendor/github.com/vishvananda/netlink/filter.go:35: undefined: nl.TcActBpf
@dongsupark
Copy link
Contributor

From a quick investigation, it looks like this issue was already fixed by vishvananda/netlink#129. I'll create a new PR to update vendor/github.com/vishvanada/netlink.
Though I don't have a Darwin host to test the build, so someone else might need to test it too.

@ewoutp
Copy link
Contributor Author

ewoutp commented Jun 13, 2016

@dongsupark Ping me in the PR, I'll be happy to test it.

dongsupark pushed a commit to dongsupark/fleet that referenced this issue Jun 13, 2016
vendor: bump github.com/vishvananda/netlink to fix build error on Darwin
1af90ca 
Bump vendor/github.com/vishvananda/netlink to commit 7995ff56 ("add
generic actions and simplify action type (coreos#129)"), to fix build errors
on Darwin hosts.
Also add vendor/github.com/vishvananda/netns for dependencies.

Fixes: coreos#1603
@dongsupark dongsupark mentioned this issue Jun 13, 2016
Merged
dongsupark pushed a commit to dongsupark/fleet that referenced this issue Jun 13, 2016
vendor: bump github.com/vishvananda/netlink to fix build error on Darwin
b75342f 
Bump vendor/github.com/vishvananda/netlink to commit 7995ff56 ("add
generic actions and simplify action type (coreos#129)"), to fix build errors
on Darwin hosts.
Also add vendor/github.com/vishvananda/netns for dependencies.

Fixes: coreos#1603
dongsupark pushed a commit to endocode/fleet that referenced this issue Jun 15, 2016
vendor: bump github.com/vishvananda/netlink to fix build error on Darwin
9a26136 
Bump vendor/github.com/vishvananda/netlink to commit 05415088e ("fix
darwin build by moving code"), to fix build errors on Darwin hosts.
Also add vendor/github.com/vishvananda/netns for dependencies.

Fixes: coreos#1603
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component/fleetctl dependency/external kind/regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vendor: bump github.com/vishvananda/netlink to fix build error on Darwin endocode/fleet
2 participants
@ewoutp @dongsupark