Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Support truthy values in boolean unit options #1108

Closed
bcwaldon opened this issue Jan 27, 2015 · 1 comment
Closed

Support truthy values in boolean unit options #1108

bcwaldon opened this issue Jan 27, 2015 · 1 comment

Comments

@bcwaldon
Copy link
Contributor

The Global option is lower-cased then checked directly against true [0], while systemd units accept "truthy" values (yes, on, 1, t) [1]. fleet should follow suit and accept the same truthy values when parsing boolean options.

[0]

return strings.ToLower(last) == "true"

[1] http://www.freedesktop.org/software/systemd/man/systemd.unit.html#Description

wuqixuan pushed a commit to wuqixuan/fleet that referenced this issue Jun 26, 2015
Support truthy values in boolean unit options(yes, on, 1, t)

Fixes coreos#1108
dongsupark pushed a commit to dongsupark/fleet that referenced this issue Apr 27, 2016
Support truthy values in boolean unit options(yes, on, 1, t).

Originally written by wuqixuan <wuqixuan@huawei.com>
Supersedes coreos#1271
Fixes: coreos#1108
dongsupark pushed a commit to dongsupark/fleet that referenced this issue Apr 29, 2016
Support truthy values in boolean unit options(yes, on, 1, t).

Originally written by wuqixuan <wuqixuan@huawei.com>
Supersedes coreos#1271
Fixes: coreos#1108
dongsupark pushed a commit to dongsupark/fleet that referenced this issue Apr 29, 2016
Support truthy values in boolean unit options(true, yes, on, 1, t).

Originally written by wuqixuan <wuqixuan@huawei.com>
Supersedes coreos#1271
Fixes: coreos#1108
dongsupark pushed a commit to dongsupark/fleet that referenced this issue May 18, 2016
Support truthy values in boolean unit options(true, yes, on, 1, t).

Originally written by wuqixuan <wuqixuan@huawei.com>
Supersedes coreos#1271
Fixes: coreos#1108
@dongsupark
Copy link
Contributor

Closed via #1574.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants