fix: Update id3 crate #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New update has these fixes: polyfloyd/rust-id3#150 polyfloyd/rust-id3#149 polyfloyd/rust-id3#148
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
=======================================
Coverage 78.67% 78.67%
=======================================
Files 139 139
Lines 32120 32120
=======================================
+ Hits 25270 25271 +1
+ Misses 6850 6849 -1 ☔ View full report in Codecov by Sentry. |
|
Do you also want to get latest main in? |
Only if there are merge conflicts. |
tmathern
approved these changes
Jan 24, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
New version of id3 has these fixes:
fix: MLLT overflow mitigation
fix: prevent panics from malformed id3 metadata #149
fix: ChunkHeader find method overflow #148
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.