Skip to content

Commit

Permalink
test: fix broken dns TXT lookup test
Browse files Browse the repository at this point in the history
It sems the TXT entry for wikipedia.org changed which is causing the
test to fail. Fix it by only checking for a partial match and use a
domain that is under our control (crc.dev).

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
  • Loading branch information
Luap99 committed Jul 23, 2024
1 parent 7782952 commit 0e970bf
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions test/basic_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,10 @@ var _ = ginkgo.Describe("dns", func() {
gomega.Expect(err).ShouldNot(gomega.HaveOccurred())
gomega.Expect(string(out)).To(gomega.ContainSubstring(`_ldap._tcp.google.com service = 5 0 389 ldap.google.com.`))
})
ginkgo.It("should resolve TXT for wikipedia.org", func() {
out, err := sshExec("nslookup -query=txt wikipedia.org")
ginkgo.It("should resolve TXT for crc.dev", func() {
out, err := sshExec("nslookup -query=txt crc.dev")
gomega.Expect(err).ShouldNot(gomega.HaveOccurred())
gomega.Expect(string(out)).To(gomega.ContainSubstring(`"v=spf1 -all"`))
gomega.Expect(string(out)).To(gomega.ContainSubstring(`text = "v=spf1`))
})

ginkgo.It("should resolve gateway.containers.internal", func() {
Expand Down

0 comments on commit 0e970bf

Please sign in to comment.