Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper use imports. #1025

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Use proper use imports. #1025

merged 1 commit into from
Mar 25, 2021

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Mar 25, 2021

Summary

I'm trying to create a binary phar of a custom project with humbug/box. My project depends on Robo.

During the compile process, Humbug will rename namespaces in order to avoid collisions. The problem is that when we import a trait with an absolute path, it fails.

In order to fix this, you have to import it properly using the proper use statement.

@greg-1-anderson
Copy link
Member

Never realized that there was an instance where use produced different results than using the fully qualified namespace + classname. In any event, looks fine to me.

@greg-1-anderson greg-1-anderson merged commit 7f4d1fa into consolidation:3.x Mar 25, 2021
@drupol drupol deleted the use-proper-use-imports-to-make-it-humbug-friendly branch March 25, 2021 21:12
@drupol
Copy link
Contributor Author

drupol commented Mar 25, 2021

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants