MINOR: fix test for windows checkSidecarOsAndArch: Should not throw exception against correct binary
#1265
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
noeldevelops
approved these changes
Mar 18, 2025
shouples
commented
Mar 18, 2025
| @@ -11,7 +11,7 @@ const platformArchToBinaryName: Map<string, string> = new Map([ | |||
| ["linux-arm64", join(binariesDir, "linux-arm64")], | |||
| ["darwin-x64", join(binariesDir, "osx-amd64")], | |||
| ["darwin-arm64", join(binariesDir, "osx-aarch64")], | |||
| ["windows-x64", join(binariesDir, "windows-x64")], | |||
There was a problem hiding this comment.
Should throw error with incorrect binary was failing because we were trying to look up win32-x64 here and returning undefined
jlrobins
approved these changes
Mar 18, 2025
jlrobins
changed the title
checkSidecarOsAndArch: Should not throw exception against correct binarycheckSidecarOsAndArch: Should not throw exception against correct binary vs windows
noeldevelops
approved these changes
Mar 18, 2025
shouples
changed the title
checkSidecarOsAndArch: Should not throw exception against correct binary vs windowscheckSidecarOsAndArch: Should not throw exception against correct binary for windows
shouples
changed the title
checkSidecarOsAndArch: Should not throw exception against correct binary for windowscheckSidecarOsAndArch: Should not throw exception against correct binary
shouples
merged commit 3fa686c
into
djs/update-ci-for-multiple-agents
1 of 2 checks passed
airlock-confluentinc bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
…exception against correct binary` (#1265)
airlock-confluentinc bot
pushed a commit
that referenced
this pull request
Mar 24, 2025
…exception against correct binary` (#1265)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
No functional changes, just a test fix for Windows. Closes #1249.
Pull request checklist
Please check if your PR fulfills the following (if applicable):
Tests
Other
.vsixfile?