CMake: Take care of zstd static lib on Win32 #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When built as a static library on Win32, zstd has output names like zstd_static.lib (Release) and zstd_staticd.lib (Debug): https://github.com/facebook/zstd/blob/69baaee3e42f90dedea2c946bc19bfeac4e782ee/build/cmake/lib/CMakeLists.txt#L141 and find_library(ZSTD zstd) will not work in such cases.
edenhill
suggested changes
May 2, 2019
| @@ -0,0 +1,28 @@ | |||
| # https://github.com/facebook/folly/blob/master/CMake/FindZstd.cmake | |||
| # | |||
There was a problem hiding this comment.
Need to include the folly license in this directory as LICENSE.FindZstd
There was a problem hiding this comment.
Hi! @edenhill Thanks for your review! I have added a license file for FindZstd.cmake: https://github.com/myd7349/librdkafka/blob/win32-zstd-static-lib/LICENSE.FindZstd
BTW, I cut these lines off: https://github.com/facebook/folly/blob/master/LICENSE#L180-L200
edenhill
reviewed
May 3, 2019
myd7349
force-pushed
the
win32-zstd-static-lib
branch
from
e4732bf to
acdc8c1
Compare
myd7349
force-pushed
the
win32-zstd-static-lib
branch
from
acdc8c1 to
83d7a3e
Compare
|
thank you! |
|
Hi! @edenhill Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When built as a static library on Win32, zstd has output names like zstd_static.lib (Release) and zstd_staticd.lib (Debug):
https://github.com/facebook/zstd/blob/69baaee3e42f90dedea2c946bc19bfeac4e782ee/build/cmake/lib/CMakeLists.txt#L141
and
find_library(ZSTD zstd)will not work in such cases.