Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snapshot): Expose config FetchTime for snapshots #55

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

SimonRichardson
Copy link
Contributor

Describe the purpose of your pull request

The following exposes the underlying config fetchTime so it's possible to
know when a given snapshot was taken. As snapshots act like readonly
encapsulations around configs, it's important to know if they're up to
date or not.

Related issues (only if applicable)

N/A

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

The following exposes the underling config fetchTime so it's possible to
know when a given snapshot was taken. As snapshots act like readonly
encapsulations around configs, it's important to know if they're up to
date or not.
@SimonRichardson SimonRichardson requested a review from a team as a code owner July 11, 2022 14:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #55 (cc390f5) into master (ce5d7b9) will decrease coverage by 0.20%.
The diff coverage is 50.00%.

❗ Current head cc390f5 differs from pull request most recent head d50566a. Consider uploading reports for the commit d50566a to get more accurate results

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   88.23%   88.03%   -0.21%     
==========================================
  Files           9        9              
  Lines        1258     1262       +4     
==========================================
+ Hits         1110     1111       +1     
- Misses        112      114       +2     
- Partials       36       37       +1     
Impacted Files Coverage Δ
v7/snapshot.go 95.00% <50.00%> (-1.33%) ⬇️
v7/config_fetcher.go 86.93% <0.00%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce5d7b9...d50566a. Read the comment docs.

@z4kn4fein
Copy link
Member

Hi @SimonRichardson, thank you for the contribution!

@z4kn4fein z4kn4fein merged commit a623382 into configcat:master Jul 12, 2022
@SimonRichardson SimonRichardson deleted the snapshot-fetcher-time branch June 21, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants