Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure pip to disable pulling in dependencies #3053

Merged
merged 3 commits into from
Aug 3, 2018
Merged

Configure pip to disable pulling in dependencies #3053

merged 3 commits into from
Aug 3, 2018

Conversation

jakirkham
Copy link
Member

Fixes #2748

We never want pip to install dependencies in the build as we will supply them ourselves.

@jakirkham jakirkham mentioned this pull request Jul 27, 2018
Closed
@jjhelmus
Copy link
Contributor

jjhelmus commented Jul 27, 2018 •
edited
Loading

Does it make sense to add env["PIP_NO_BUILD_ISOLATION"] = False as well to disable build isolation?

Nevermind, just saw that it is already there.

@jakirkham
Copy link
Member Author

Yeah was just trying to figure out if we were doing that or not earlier as well. Seems like we are, which is good.

@jakirkham
Copy link
Member Author

Looks like there are a couple CI failures related to some rpm test where the HTTP request fails. Seems unrelated. Also one Travis CI test timed out.

@msarahan msarahan mentioned this pull request Jul 30, 2018
Closed
@jakirkham jakirkham force-pushed the more_pip_env_vars branch from 48ceb99 to 6fdf30a Compare July 30, 2018 17:20
jakirkham added 2 commits July 30, 2018 13:22
@jakirkham
Configure pip to disable pulling in dependencies
12975ec 
We never want `pip` to install dependencies in the build as we will
supply them ourselves.
@jakirkham
Disable usage of pip's cache
7232a25 
We don't want to rely on pip's cache when building packages. Instead we
would rather fetch anything we need each time.
@jakirkham jakirkham force-pushed the more_pip_env_vars branch from 6fdf30a to 7232a25 Compare July 30, 2018 17:22
@msarahan
Copy link
Contributor

msarahan commented Aug 3, 2018

Added some small comments about the counterintuitive logic of the "NO" env vars. Thanks @jakirkham

@msarahan msarahan merged commit 8cb9ee0 into conda:master Aug 3, 2018
@jakirkham jakirkham deleted the more_pip_env_vars branch August 3, 2018 18:06
@jakirkham
Copy link
Member Author

Thanks @msarahan.

Yeah the "NO" environment variables are still very weird. In addition to the counterintuitive logic, some of them will crash if set incorrectly (as they expect more arguments).

xref: pypa/pip#2897

@msarahan
Copy link
Contributor

msarahan commented Aug 3, 2018

Frustrating, but at least they are consistent.

@jjhelmus jjhelmus mentioned this pull request Aug 24, 2018
Closed
@tjd2002 tjd2002 mentioned this pull request Dec 13, 2018
Open
@jjhelmus jjhelmus mentioned this pull request Dec 13, 2018
Closed
@github-actions
Copy link

Hi there, thank you for your contribution!

This pull request has been automatically locked because it has not had recent activity after being closed.

Please open a new issue or pull request if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
locked [bot] locked due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure pip during build to avoid dependencies
3 participants
@jakirkham @jjhelmus @msarahan