Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix artefact_destination make_available #95

Merged
merged 1 commit into from
Nov 15, 2017
Merged

Fix artefact_destination make_available #95

merged 1 commit into from
Nov 15, 2017

Conversation

bjlittle
Copy link
Contributor

@bjlittle bjlittle commented Nov 15, 2017 •
edited
Loading

This PR addresses #94 raised by @LukeC92

@bjlittle
Copy link
Contributor Author

closes #94

@bjlittle
Copy link
Contributor Author

bjlittle commented Nov 15, 2017 •
edited
Loading

@pelson @msarahan @jakirkham Fancy taking a look ...

@bjlittle bjlittle mentioned this pull request Nov 15, 2017
Merged
@pelson
Copy link
Contributor

pelson commented Nov 15, 2017

Looks good. Should now handle the creation of multiple build artefacts... 👍

@pelson pelson merged commit 742efce into conda-tools:master Nov 15, 2017
@pelson pelson self-assigned this Nov 15, 2017
@LukeC92 LukeC92 mentioned this pull request Nov 15, 2017
Closed
@bjlittle
Copy link
Contributor Author

@pelson Awesome thanks!

@conda-tools/core Could I push for this PR forcing a point release v1.1.3 of conda-build-all ? I don't have the rights to do so myself ...

@pelson
Copy link
Contributor

pelson commented Nov 15, 2017

Could I push for this PR forcing a point release v1.1.3 of conda-build-all ?

Yep. Did that already.

@conda-tools/core - I propose adding @bjlittle to the core team. Rather than adding him myself, could I ask another person to agree/disagree and add him to the team?

@jakirkham
Copy link
Member

Happy to add @bjlittle. 👍

@pelson
Copy link
Contributor

pelson commented Nov 15, 2017

Thanks @jakirkham - I went ahead and did it after your comment. I've tidied up some of the team permissions on the org too. If there any un-intended side-effects, please ping me and I'll correct. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pelson pelson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjlittle @pelson @jakirkham