Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package for ampl-asl C library #28198

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Nov 13, 2024

The PR adds a recipe for the ampl-asl library (repology page: https://repology.org/project/ampl-asl/). The naming of the recipe and the package mirrors the one of the related package ampl-mp, maintained at https://github.com/conda-forge/ampl-mp-feedstock .

This package is now added as ampl-mp 4.0.0 is not vendoring anymore ampl-asl, so we need to package it as separate project, see:

Furthermore, as ipopt actually just depends on asl, by packaging ampl-asl we can just depend on ampl-asl rather then depend on ampl-mp that also includes a public ampl-asl vendored library.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ampl-asl/meta.yaml) and found some lint.

Here's what I've got...

For recipes/ampl-asl/meta.yaml:

  • requirements: run_constrained: ampl-mp>=4.0.0 must contain a space between the name and the pin, i.e. ampl-mp >=4.0.0

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ampl-asl/meta.yaml) and found it was in an excellent condition.

@traversaro traversaro changed the title Add ampl-asl Add package for ampl-asl C library Nov 13, 2024
@traversaro
Copy link
Contributor Author

@conda-forge/staged-recipes @conda-forge/help-c-cpp @conda-forge/ipopt @conda-forge/ampl-mp the PR is ready for review.

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@xhochy xhochy merged commit e8cae9e into conda-forge:main Nov 22, 2024
7 checks passed
@traversaro
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants